Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ziming Zhu" <zmzhu0630@163.com>
Cc: robh@kernel.org, conor+dt@kernel.org,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] hwmon: Add documentation for SQ24860
Date: Fri, 05 Jun 2026 02:12:26 +0000	[thread overview]
Message-ID: <20260605021226.618D01F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260605020450.89638-4-zmzhu0630@163.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The documentation incorrectly refers to the device tree property as `sy,rimon-micro-ohms` instead of `silergy,rimon-micro-ohms`.
--

commit a85c00a013d8414f7f994a494095e98e35abc82a
Author: Ziming Zhu <ziming.zhu@silergycorp.com>

hwmon: Add documentation for SQ24860

This commit adds documentation for the Silergy SQ24860 PMBus hwmon driver,
detailing supported sysfs attributes and device tree configurations.

> diff --git a/Documentation/hwmon/sq24860.rst b/Documentation/hwmon/sq24860.rst
> new file mode 100644
> index 0000000000000..7029f612e1b96
> --- /dev/null
> +++ b/Documentation/hwmon/sq24860.rst

[ ... ]

> +The current and power measurement scale depends on the resistor connected
> +between the IMON pin and ground. The resistor value can be configured with the
> +``sy,rimon-micro-ohms`` device tree property. See

[Severity: Low]
This isn't a bug, but is this property name correct?

The documentation refers to the device tree property as "sy,rimon-micro-ohms",
but the driver code explicitly expects "silergy,rimon-micro-ohms". Could this
discrepancy mislead users when configuring their device trees?

> +``Documentation/devicetree/bindings/hwmon/pmbus/silergy,sq24860.yaml`` for details.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605020450.89638-1-zmzhu0630@163.com?part=3

  reply	other threads:[~2026-06-05  2:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05  2:04 [PATCH 0/3] *** Add support for Silergy SQ24860 *** Ziming Zhu
2026-06-05  2:04 ` [PATCH 1/3] dt-bindings: hwmon: pmbus: Add bindings for Silergy SQ24860 Ziming Zhu
2026-06-05  2:11   ` sashiko-bot
2026-06-05  2:04 ` [PATCH 2/3] hwmon: pmbus: Add support " Ziming Zhu
2026-06-05  2:16   ` sashiko-bot
2026-06-05  2:04 ` [PATCH 3/3] hwmon: Add documentation for SQ24860 Ziming Zhu
2026-06-05  2:12   ` sashiko-bot [this message]
2026-06-05  4:36   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260605021226.618D01F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zmzhu0630@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox