From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A49413264DD; Fri, 5 Jun 2026 03:49:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780631376; cv=none; b=oFEfn0FcMbjsONiGr1pNdTyKrYKA5IZMK8vZ7vy3X7RinKj4vKjJGbtPkgu+KN03dxnumY5rvrBszQ5eXeko94jboIm4dFyAkBLKoOLt/VtxM53wccIedYsC0thJWzYpcwl+JxFhIt5MISBFnj1nJvuKe6HJZwWfyMZiFuHXX6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780631376; c=relaxed/simple; bh=lXTpcmAkaEpwn5t82yvuAd3o09rJpVtkSBabO4ghCt8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=YxDZObPZE3q5UM8lA9lIYstt8eB7Rv0p5PP4GMDL99QYxecYr58SUNBB9zNz/jRX/5i+qKCwAG62ZQQbAJGZ5i+vcPlD1Tg2ztBeOWAZFS42ZJR8KevBzuIWEhp5KXclDsEEo1uOhEwITtcdlwDkWkVXqbfDBinIIKDGkBXmoPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dPTP4IwC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dPTP4IwC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F15F11F00893; Fri, 5 Jun 2026 03:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780631375; bh=V+i9sV626KtxQpclHZKn0AzcvWcKSOmXs1bxRGOkc64=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dPTP4IwCwZrRzBHac8U76uJIDHGlycobotNozHRVU1du7R6rk4jYAQneLUvDkGesZ liCxUeQMiXYXZV/PWV02Jre62Kkvu0drr8TkP/Ywz5luvTftsm8G8AGs4mgu393vfX S4N/rjF1GzeGuK1HmT47hIUqOoPJIcIE5yeo2V3Daw33Ji69ypAnGzuJGivaROWSDq P3npfTCRm5LjSY2fkofv2TQXeiZEz0VMGXbqoFY9eGSwwGMLaHrb4KWmR0B7WOn9s3 YfHvj870E6GGQXfGmESvHAT1jJ42dLzxlEXGTMdqPwZUu2+AX+8ykk+5Uy/rz3VW6b W7cfanAiwV22A== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: add aptina,mt9m113 Reply-To: sashiko-reviews@lists.linux.dev To: "Herman van Hazendonk via B4 Relay" Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, linux-media@vger.kernel.org In-Reply-To: <20260605-submit-media-mt9m113-v2-1-de1cc807f4cf@herrie.org> References: <20260605-submit-media-mt9m113-v2-1-de1cc807f4cf@herrie.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 05 Jun 2026 03:49:34 +0000 Message-Id: <20260605034934.F15F11F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Low] Missing schema length constraints for `reset-gpios` and `powerdown-= gpios` arrays. - [Low] Binding strictly rejects standard camera properties by not referenc= ing `video-interface-devices.yaml`. -- commit 63f988e66ed5aa2849614f19a1ca36bc01146bb7 Author: Herman van Hazendonk dt-bindings: media: i2c: add aptina,mt9m113 Adds a new device tree binding for the Aptina MT9M113 1.3 megapixel image sensor. The binding details the I2C address, optional GPIOs, regulators, and the MIPI CSI-2 port configuration. > diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.y= aml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml > new file mode 100644 > index 0000000000000..7fa7cb2fedf96 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml > @@ -0,0 +1,127 @@ [ ... ] > + vaa-supply: > + description: > + Analog voltage supply, 2.8V > + > + reset-gpios: > + description: |- > + Reference to the GPIO connected to the RESET_BAR pin, if any (acti= ve > + low). > + > + powerdown-gpios: > + description: |- > + Reference to the GPIO connected to the STANDBY/PWDN pin, if any (a= ctive > + high). When asserted, the sensor enters low-power standby mode. [Severity: Low] Should these properties include a maxItems: 1 constraint?=20 In Device Tree schemas, properties with the -gpios suffix map to arrays. Without an explicit maximum length, dt-schema validation might allow arrays of any length to pass. Since the hardware has exactly one reset pin and one standby pin, enforcing a limit of 1 seems appropriate here to ensure strict validation. > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base [ ... ] > +required: > + - compatible > + - reg > + - clocks > + - vdd-supply > + - vddio-supply > + - vaa-supply > + - port > + > +additionalProperties: false [Severity: Low] Does this schema need a reference to=20 /schemas/media/video-interface-devices.yaml# before strictly disallowing additional properties? Camera sensors frequently require standard physical properties like rotatio= n, orientation, or flash-leds to describe how they are mounted on the board. Setting additionalProperties to false without including the standard video interface device schema will erroneously reject valid device trees that use these common properties. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260605-submit-med= ia-mt9m113-v2-0-de1cc807f4cf@herrie.org?part=3D1