From: sashiko-bot@kernel.org
To: "Ziming Zhu" <zmzhu0630@163.com>
Cc: linux-hwmon@vger.kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 3/3] hwmon: Add documentation for SQ24860
Date: Fri, 05 Jun 2026 06:36:12 +0000 [thread overview]
Message-ID: <20260605063612.B760B1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260605063042.91776-4-zmzhu0630@163.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 'Hardware Monitoring Kernel Drivers' index list in `Documentation/hwmon/index.rst` is maintained in alphabetical order. The commit incorrectly inserts `sq24860` between `sparx5-temp` and `spd5118`. Alphabetically, 'sq' comes after 'sp', so `sq24860` should be placed after `spd5118` and before `stpddc60`.
--
commit 65caf89dcee60b08d75fdadfaa3541e74096b753
Author: Ziming Zhu <ziming.zhu@silergycorp.com>
hwmon: Add documentation for SQ24860
This commit documents the supported sysfs attributes for the Silergy SQ24860
PMBus hwmon driver.
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index 8b655e5d6b68b..1888905cd2349 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -242,6 +242,7 @@ Hardware Monitoring Kernel Drivers
> smsc47m192
> smsc47m1
> sparx5-temp
> + sq24860
> spd5118
[Severity: Low]
This isn't a bug, but the Hardware Monitoring Kernel Drivers index list is
typically maintained in alphabetical order.
Since sq comes after sp, should sq24860 be placed after spd5118 and before
stpddc60 to maintain this sorting?
> stpddc60
> surface_fan
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260605063042.91776-1-zmzhu0630@163.com?part=3
prev parent reply other threads:[~2026-06-05 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 6:30 [PATCH v2 0/3] Add support for Silergy SQ24860 Ziming Zhu
2026-06-05 6:30 ` [PATCH v2 1/3] dt-bindings: hwmon: pmbus: Add bindings " Ziming Zhu
2026-06-05 6:35 ` sashiko-bot
2026-06-05 6:30 ` [PATCH v2 2/3] hwmon: pmbus: Add support " Ziming Zhu
2026-06-05 6:41 ` sashiko-bot
2026-06-05 6:30 ` [PATCH v2 3/3] hwmon: Add documentation for SQ24860 Ziming Zhu
2026-06-05 6:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605063612.B760B1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zmzhu0630@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox