Re: [PATCH v3 1/2] dt-bindings: media: i2c: add aptina,mt9m113

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `reset-gpios` and `powerdown-gpios` properties lack the `maxItems: 1` constraint.
--

commit 5ab8d70c4704ffb84f721fd8458f27f181d12b4a
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: media: i2c: add aptina,mt9m113

This commit introduces the device tree binding for the Aptina MT9M113 1.3
megapixel image sensor. It defines the required and optional properties,
including the I2C address, regulators, and GPIOs for reset and powerdown.

> diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml
> new file mode 100644
> index 0000000000000..7fa7cb2fedf96
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml
[ ... ]
> @@ -0,0 +1,127 @@
[ ... ]
> +  vaa-supply:
> +    description:
> +      Analog voltage supply, 2.8V
> +
> +  reset-gpios:
> +    description: |-
> +      Reference to the GPIO connected to the RESET_BAR pin, if any (active
> +      low).

[Severity: Low]
Does this property need a maxItems constraint? Since the MT9M113 hardware has
exactly one RESET_BAR pin, adding maxItems: 1 would prevent the schema from
silently permitting invalid device trees that specify multiple GPIOs here.

> +
> +  powerdown-gpios:
> +    description: |-
> +      Reference to the GPIO connected to the STANDBY/PWDN pin, if any (active
> +      high). When asserted, the sensor enters low-power standby mode.

[Severity: Low]
Should we also limit powerdown-gpios with a maxItems: 1 constraint to properly
match the single STANDBY/PWDN pin on the hardware?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-submit-media-mt9m113-v3-0-dc3e07d5d70b@herrie.org?part=1