Re: [PATCH v2 1/2] dt-bindings: leds: Add default-intensity property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Driver-specific name hardcoded in the generic `common.yaml` schema description.
--

commit 9beb7b4f88908b2864bd519c143e1a370071aec1
Author: Jonas Rebmann <jre@pengutronix.de>

dt-bindings: leds: Add default-intensity property

This commit documents the default-intensity property to set a default color
on multicolor LEDs. It also updates the pwm-multicolor binding and its
example to support this new initialization property.

> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f4e44b33f56d1..a34de0a34b422 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml

[ ... ]

> @@ -73,6 +73,17 @@ properties:
>        - keep
>      default: off
>  
> +  default-intensity:
> +    description:
> +      The initial intensity of the LED color component. Used only during
> +      initialization. Defaults to 0. As the intensity of each sub-LED is
> +      multiplied with the overall brightness, without this property on a
> +      sub-LED, the leds-pwm-multicolor-LED is effectively initialized at
> +      minimum brightness regardless of its linux,default-trigger and
> +      default-brightness properties.

[Severity: Low]
This isn't a bug, but the description for default-intensity explicitly
mentions the specific driver name leds-pwm-multicolor-LED.

Since common.yaml is intended to be a hardware-agnostic specification
for all LED bindings, could this wording be updated to refer generically
to the multicolor LED or simply the LED to avoid leaking an
implementation detail into the generic schema?

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 0
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-multicolor-default-v2-0-ed07271df6b0@pengutronix.de?part=1