Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alexander Koskovich" <akoskovich@pm.me>
Cc: dri-devel@lists.freedesktop.org, robh@kernel.org,
	devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: Document Raydium RM69220 DDIC
Date: Fri, 05 Jun 2026 18:34:33 +0000	[thread overview]
Message-ID: <20260605183434.273CE1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260605-asteroids-panel-support-v2-1-44b96c6eca91@pm.me>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added DT binding schema introduces a dtbs_check regression for an existing dummy panel node in `arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts`. The existing device tree uses `compatible = "boe,bf068mwm-td0"` for a simple-framebuffer dummy node, but lacks the strictly required properties mandated by the new schema.
--

commit 6315e592e65e15de511f78a600454fa1ddbaf9e2
Author: Alexander Koskovich <akoskovich@pm.me>

dt-bindings: display: panel: Document Raydium RM69220 DDIC

Document the Raydium RM69220 DDIC and the BOE BF068MWM-TD0 6.77"
1080x2392 AMOLED display panel used in the Nothing Phone (3a).

> diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm69220.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm69220.yaml
> new file mode 100644
> index 0000000000000..7423b192d892c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm69220.yaml
[ ... ]
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - boe,bf068mwm-td0
> +      - const: raydium,rm69220

[Severity: Low]
Will this strict compatible requirement trigger dtbs_check failures for the
existing dummy panel node in
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts?

That file currently uses this compatible string for a dummy node:

			/* Dummy panel for simple-framebuffer dimension info */
			panel: dummy-panel {
				compatible = "boe,bf068mwm-td0";
				height-mm = <157>;
				width-mm = <71>;
			};

Since the new schema mandates a two-item array with "raydium,rm69220" and
several other required properties like dvdd-supply, reg, and port, validating
the existing dts against this schema appears to cause validation failures.

Should the dummy node's compatible string be updated to avoid conflicting with
the actual hardware schema, or should the dts update be included in this
series?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-asteroids-panel-support-v2-0-44b96c6eca91@pm.me?part=1

  reply	other threads:[~2026-06-05 18:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05 18:27 [PATCH v2 0/2] Add support for the BOE BF068MWM-TD0 Alexander Koskovich
2026-06-05 18:27 ` [PATCH v2 1/2] dt-bindings: display: panel: Document Raydium RM69220 DDIC Alexander Koskovich
2026-06-05 18:34   ` sashiko-bot [this message]
2026-06-05 18:37     ` Alexander Koskovich
2026-06-05 18:27 ` [PATCH v2 2/2] drm/panel: Add driver for " Alexander Koskovich
2026-06-05 18:44   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260605183434.273CE1F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akoskovich@pm.me \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox