Re: [PATCH 2/3] irqchip: irq-crossbar: Handle renamed irqs-reserved property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch uses double quotes for including a system kernel header (`#include "linux/of.h"`) instead of angle brackets (`#include <linux/of.h>`).
--

commit 45bcc0524f9b113a66a6033e639fbb294bcfc7da
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

irqchip: irq-crossbar: Handle renamed irqs-reserved property

This commit updates the TI IRQ Crossbar driver to handle a renamed device
tree property. It tries ti,crossbar-irqs-reserved first and falls back to
ti,irqs-reserved to maintain backward compatibility with older device trees.

> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
> index cd1134101ace0..64b042ce11a9a 100644
> --- a/drivers/irqchip/irq-crossbar.c
> +++ b/drivers/irqchip/irq-crossbar.c
> @@ -5,6 +5,7 @@
>   *  Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com
>   *  Author: Sricharan R <r.sricharan@ti.com>
>   */
> +#include "linux/of.h"

[Severity: Low]
This isn't a bug, but looking at the global includes in
drivers/irqchip/irq-crossbar.c, should this include use angle brackets
instead of double quotes? Standard kernel coding style expects <linux/of.h>
for system headers, as using double quotes forces the preprocessor to search
the local directory first.

>  #include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/irqchip.h>

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260606-crossbar-v1-0-f67f7cb9ee50@gmail.com?part=2