From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166D022157B; Sat, 6 Jun 2026 01:01:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780707685; cv=none; b=FCgPAFORESljLcIVkGPA9TTDiQXk0iYJNAoGO5FpJjR858c3ifm8dJykCUnWNVEBGv767qKR239p0kvJwYbmv2TyEORCDv1de87r4oX8uULhtUEJNVKVPekcROG/JQjDQ+7hIFbSmdfHamkfqTe+x/kDu6Er9yKWGjwiORLwKXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780707685; c=relaxed/simple; bh=axisrcMlKNXae4n5ynJzdI9g+w7xmWFxiQ49t7gOoqQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ZPzXZbNpiiiqplAvOtLCvBvaXHMeLfRs4BAdPSx0mGVKYfuWYfbYeTTqzMoUCT+Ji1BW6mkpws05qf8bhJsSK0LogHO9M8rFROB1tAyCHvDLkDd5KBbolvVJcEHSVuib5JRtUYMf1izlS4u/gsYQlxRa6caStjJLBsjGmhYDM7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KpIMnnY3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KpIMnnY3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B07D01F0089A; Sat, 6 Jun 2026 01:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780707684; bh=ZaNVmPRZAoLAImGnhWU1P6cdf0SRoHr9ImqdiBE8VfI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KpIMnnY3z9W4KH7bU0UOtT50DT9j7O1oJcgpdctjTX9NvBeAuV/NqZHx58NAOvbyA HOOVJmaPnxtEwAAeNx+2aXJagIqigiUJcNtRx7eMJaHUO+iZzplXxQ1x57Srl56MQV OS9FQveEWTEOl5yy+3on/b3/OLootnF9Boqnuz88M5iWxOOrvS9g19UIGkbvhbOHu/ YlgxcuH9pTFSd3FZEo14xWpdlNvvKtLibA0JF/r8wygd0Kmsk2A+L1rk6tdv/Yk/Xi Be2IVrr/H5iqEjzYq1z3R44/Gmnej7CEA/9cFtxKAOKtXRXB86q2UmkeveA+vpAL7E RQC+4XdU6RfQg== From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v2 03/14] net: pcs: pcs-xpcs-regmap: support XPCS memory-mapped MDIO bus via regmap Reply-To: sashiko-reviews@lists.linux.dev To: "Alex Elder" Cc: robh@kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260605010022.968612-4-elder@riscstar.com> References: <20260605010022.968612-4-elder@riscstar.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jun 2026 01:01:23 +0000 Message-Id: <20260606010123.B07D01F0089A@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Missing colon ':' after 'F' in the MAINTAINERS file entry. -- commit 2d23c3db72012c33d05246dcd5eb68b21952d164 Author: Daniel Thompson net: pcs: pcs-xpcs-regmap: support XPCS memory-mapped MDIO bus via regmap This commit introduces helpers to allow drivers to register an XPCS using a regmap for the memory-mapped MDIO bus. It addresses issues where the MDIO bus is allocated to a register window that does not align to a page boundar= y. > diff --git a/MAINTAINERS b/MAINTAINERS > index eb8cdcc76324f..2aa6ea012c848 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -25931,8 +25931,10 @@ F: drivers/net/ethernet/synopsys/ > SYNOPSYS DESIGNWARE ETHERNET XPCS DRIVER > L: netdev@vger.kernel.org > S: Orphan > +F: drivers/net/pcs/pcs-xpcs-regmap.c > F: drivers/net/pcs/pcs-xpcs.c > F: drivers/net/pcs/pcs-xpcs.h > +F include/linux/pcs/pcs-xpcs-regmap.h [Severity: Low] This isn't a bug, but should this entry have a colon after the 'F'? > F: include/linux/pcs/pcs-xpcs.h --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260605010022.9686= 12-1-elder@riscstar.com?part=3D3