Re: [PATCH v5 1/2] dt-bindings: media: i2c: add aptina,mt9m113

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema lacks a `data-lanes` constraint, allowing invalid configurations to pass validation.
--

commit 79e83e3556be09a3d2a83b67549cbb782161a0a4
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: media: i2c: add aptina,mt9m113

This commit adds the device tree binding schema for the Aptina MT9M113
1.3 megapixel CMOS digital image sensor. It describes I2C addressing,
regulators, clocks, GPIOs, and the MIPI CSI-2 connection port.

> diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml
> new file mode 100644
> index 0000000000000..72b827c47b1d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml

[ ... ]

> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          bus-type:
> +            const: 4
> +            description: MIPI CSI-2 D-PHY

[Severity: Low]
The commit message mentions that the sensor outputs image data over a
1-lane MIPI CSI-2 connection. Should this endpoint block include a
constraint for the data-lanes property to restrict it to a single lane?

Since video-interfaces.yaml permits up to 8 data lanes, omitting a
data-lanes restriction here (such as maxItems: 1) would allow invalid
multi-lane device tree configurations to silently pass schema validation.

> +
> +        required:
> +          - bus-type
> +          - link-frequencies

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260606-submit-media-mt9m113-v5-0-2088c7358e11@herrie.org?part=1