Re: [PATCH v3 1/2] dt-bindings: interconnect: qcom: add msm8660 NoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema inherits a deprecation warning by referencing `qcom,rpm-common.yaml#` while explicitly using the deprecated `#interconnect-cells = <1>`.
--

commit 5ce31b27e0895bb0c743c163991a0db815e92b7e
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: interconnect: qcom: add msm8660 NoC
    
This commit adds a dt-binding schema and interconnect master/slave ID header
for the Qualcomm MSM8x60 family (MSM8260/MSM8660/APQ8060) Network-on-Chip.
The chip exposes four NoC fabrics modelled as interconnect providers which
program arbitration through RPM firmware.

> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8660.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8660.yaml
> new file mode 100644
> index 0000000000000..ff28c7d46c323
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8660.yaml
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,msm8660-apps-fabric
> +      - qcom,msm8660-system-fabric
> +      - qcom,msm8660-mmss-fabric
> +      - qcom,msm8660-daytona-fabric
> +
> +  '#interconnect-cells':
> +    const: 1
> +    description:
> +      Each consumer phandle takes the form <provider node-id> where node-id
> +      indexes the per-fabric ID array in
> +      <dt-bindings/interconnect/qcom,msm8660.h>.  qcom,rpm-common.yaml
> +      permissively allows 2 cells (and 1 marked deprecated); pin this
> +      provider to 1, which is what of_icc_xlate_onecell strictly expects.
[ ... ]
> +allOf:
> +  - $ref: qcom,rpm-common.yaml#

[Severity: Low]
Does referencing qcom,rpm-common.yaml# here cause a deprecation warning to
be emitted during dt_binding_check?

Because this binding explicitly forces '#interconnect-cells: const: 1', and
qcom,rpm-common.yaml marks 1-cell as deprecated, wouldn't evaluating
any valid DT node for this provider trigger a warning?

Since qcom,rpm-common.yaml defines no other meaningful constraints (it
specifies additionalProperties: true), does referencing it here provide any
functional value, or would it be better to remove the reference to avoid
build warning pollution?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260606-submit-interconnect-msm8660-v3-0-f9da0158cdf8@herrie.org?part=1