From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2887B22D781; Sat, 6 Jun 2026 15:16:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780759020; cv=none; b=H0KfYyQCLLdDCDczgkQyGKz/hc08543SY6SWuhI1dZGWaQQr8QbEhBx0a4OpS5o6zoTcVvBwclCUMKm1+xXYmeDmuIL0EDUrSXEKL/Hf601Ru1LSDaNJX7DYqdfUY2VMTJfD6yKkJYz+a1zhs7QC7KWvEiN/EosdZfzDN+XMhbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780759020; c=relaxed/simple; bh=47kWpJuAJTbiDrQtze80qDzgl5xgbb0ABeCoNCv+D60=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=d6KhLIZKQVumCNo7dlcd/2+2i3jqSYwJMm1uhodtETMoMiJnenPINls1uqDQKqE4E/ENDj3RChepAUQLTraOUjV4vzk2lTQJY4kYNwiUAqJt7mCq6INZnTOV9AcAt9AT7iO598dbKo578jcMnNVGmmiVXiu7DBBliXGQ0k0cH60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kk7+ZE9l; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kk7+ZE9l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E2C1F00893; Sat, 6 Jun 2026 15:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780759018; bh=lD7TouPlf3gsrcHa1VjE35nehhJc6OhqW6fhuo4khls=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=kk7+ZE9l+pEoPZmxtZMXFx/ytcRBz+xwq1CmdWItB5jP80xE0J7wJMAceDAgf46I0 w/7vz5FMN6D2toTv9+dSaWxlp0MqUn1SXfAKFgAkAhglUKYT7uaFx5CuHemOFeuFFM XLSKKCd803nJ4OR822VfWhUd6vyAAEH8snxaiMW2R/5G+P1HrUt4Shhd6kYepZkMTR Kq0DhQQbWgvco37XMMeSZm2YoqBwFcXrzG1I1JqictpmmyGxhuJjZbK1NUcBWd4utX E6jEcSgimT/qi+azRA2tLp3YqkL6Yxh9VasYHr5RjfxgRVHV++Vs+pb96sl1tPUcgd AF+3/oEuzrCsw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 7/8] dt-bindings: input: microchip,cap11xx: Add CAP1114 support Reply-To: sashiko-reviews@lists.linux.dev To: "Jun Yan" Cc: robh@kernel.org, dmitry.torokhov@gmail.com, devicetree@vger.kernel.org, linux-input@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260606150458.250606-8-jerrysteve1101@gmail.com> References: <20260606150458.250606-8-jerrysteve1101@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jun 2026 15:16:57 +0000 Message-Id: <20260606151658.60E2C1F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The new `microchip,cap1114` compatible string was omitted from t= he `if-then` conditional block that restricts `microchip,signal-guard` and = `microchip,calib-sensitivity` for prior CAP11xx generations. -- commit 5c58a6baee363da7434a9782efa913c250015130 Author: Jun Yan dt-bindings: input: microchip,cap11xx: Add CAP1114 support This commit adds device tree binding support for the CAP1114 capacitive touch sensor. It updates the compatible string list, maximum LED channel counts, and keycode entries. > diff --git a/Documentation/devicetree/bindings/input/microchip,cap11xx.ya= ml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml > index e307628350c24..08233386a4336 100644 > --- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml > +++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml [ ... ] > @@ -26,6 +27,7 @@ properties: > compatible: > enum: > - microchip,cap1106 > + - microchip,cap1114 > - microchip,cap1126 > - microchip,cap1188 > - microchip,cap1203 [Severity: Medium] Since microchip,cap1114 is being added here, could this validation regression be avoided by also appending it to the if-then conditional block further down the schema that restricts microchip,signal-guard and microchip,calib-sensitivity? Documentation/devicetree/bindings/input/microchip,cap11xx.yaml: - if: properties: compatible: contains: enum: - microchip,cap1106 - microchip,cap1126 - microchip,cap1188 - microchip,cap1203 - microchip,cap1206 then: properties: microchip,signal-guard: false microchip,calib-sensitivity: false Since the maxItems for these properties remains at 8 (and CAP1114 has 14 channels), it appears CAP1114 does not support them either. Omitting the new compatible string from this block allows device trees with these unsupported properties to pass schema validation. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260606150458.2506= 06-1-jerrysteve1101@gmail.com?part=3D7