From: sashiko-bot@kernel.org
To: "Lukas Schmid" <lukas.schmid@netcube.li>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v3 3/3] ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann)
Date: Sat, 06 Jun 2026 19:26:33 +0000 [thread overview]
Message-ID: <20260606192633.E930A1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260606191649.2347704-4-lukas.schmid@netcube.li>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree source file is incorrectly added to the Makefile with a `.dts` extension instead of `.dtb`, which prevents the build system from generating the compiled device tree blob.
--
commit 050625703589dd3473dcaea2f70357c5bd2c45b5
Author: Lukas Schmid <lukas.schmid@netcube.li>
ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann)
This commit adds device tree support for the NetCube Systems OpenNMC board,
which acts as an open replacement for APC SmartSlot Management Cards based on
the Nagami System-on-Module.
> diff --git a/arch/arm/boot/dts/allwinner/Makefile b/arch/arm/boot/dts/allwinner/Makefile
> index f71392a55df87..220a20734dc24 100644
> --- a/arch/arm/boot/dts/allwinner/Makefile
> +++ b/arch/arm/boot/dts/allwinner/Makefile
[ ... ]
> @@ -261,6 +262,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
> sun8i-s3-lichee-zero-plus.dtb \
> sun8i-s3-pinecube.dtb \
> sun8i-t113s-mangopi-mq-r-t113.dtb \
> + sun8i-t113s-netcube-dobermann.dts \
[Severity: Low]
Does this target need to use the .dtb extension instead of .dts? Kbuild
expects the compiled device tree blob targets in the dtb-y lists to resolve
the compilation rules. Listing the source .dts file here might cause the build
system to skip compiling the new device tree blob entirely.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260606191649.2347704-1-lukas.schmid@netcube.li?part=3
prev parent reply other threads:[~2026-06-06 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 19:16 [PATCH v3 0/3] Add support for NetCube Systems OpenNMC (dobermann) Lukas Schmid
2026-06-06 19:16 ` [PATCH v3 1/3] dt-bindings: arm: sunxi: Add " Lukas Schmid
2026-06-06 19:16 ` [PATCH v3 2/3] riscv: dts: allwinner: d1s-t113: Add uart4 pinctrl required by NetCube Systems OpenNMC Lukas Schmid
2026-06-06 19:16 ` [PATCH v3 3/3] ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann) Lukas Schmid
2026-06-06 19:26 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260606192633.E930A1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lukas.schmid@netcube.li \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox