Re: [PATCH 4/5] ASoC: qcom: sc8280xp: Add per-card data

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect DAPM pin mask for 'Mic Jack' in qcs6490_rubikpi3_headset_jack_pins causes microphone detection failure.
--

commit 869054356ad0f6ae035a50e1d5d5e99577638b9b
Author: Hongyang Zhao <hongyang.zhao@thundersoft.com>

ASoC: qcom: sc8280xp: Add per-card data

This commit converts the sc8280xp machine driver match data to a per-card data
structure to support board-specific MI2S codec requirements. It adds data for
the QCS6490 RubikPi3 and a common headset jack helper.

> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> index 7925aa3f63ba0..1ccd7437cc52d 100644
> --- a/sound/soc/qcom/sc8280xp.c
> +++ b/sound/soc/qcom/sc8280xp.c

[ ... ]

> +static struct snd_soc_jack_pin qcs6490_rubikpi3_headset_jack_pins[] = {
> +	{
> +		.pin = "Mic Jack",
> +		.mask = SND_JACK_HEADPHONE,

[Severity: Medium]
Does this mask prevent correct DAPM routing for the microphone? It looks like
SND_JACK_HEADPHONE is used instead of SND_JACK_MICROPHONE for the Mic Jack pin.

> +	},
> +	{
> +		.pin = "Headphone Jack",
> +		.mask = SND_JACK_HEADPHONE,
> +	},
> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260607-rubikpi-next-20260605-v1-0-7f334e16fea6@thundersoft.com?part=4