Re: [PATCH v6 1/2] dt-bindings: i2c: ls2x-i2c: Add clocks and clock-frequency properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding the `clocks` property to the device tree example without defining it in the `properties` block causes schema validation (`make dt_binding_check`) to fail.
--

commit e568ab3d299f8c59baf7b2a2ee43cbee837517fd
Author: Hongliang Wang <wanghongliang@loongson.cn>

dt-bindings: i2c: ls2x-i2c: Add clocks and clock-frequency properties

This commit adds the clock-frequency and clocks properties to the device
tree examples for the loongson,ls2x-i2c binding.

> diff --git a/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml b/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> --- a/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
[ ... ]
>  examples:
>    - |
> +    #include <dt-bindings/clock/loongson,ls2k-clk.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
>  
>      i2c0: i2c@1fe21000 {
>          compatible = "loongson,ls2k-i2c";
>          reg = <0x1fe21000 0x8>;
> +        clock-frequency = <100000>;
> +        clocks = <&clk LOONGSON2_APB_CLK>;

[Severity: Low]
Will this addition to the examples block cause make dt_binding_check to fail?

The loongson,ls2x-i2c.yaml schema sets unevaluatedProperties: false. This
strictly limits allowed properties to those explicitly defined in the schema
itself or inherited via references. While clock-frequency is inherited from
the standard i2c-controller.yaml reference, the clocks property does not
appear to be defined anywhere in the local properties block.

Because clocks is undeclared, adding it here will likely cause the schema
validation tooling to reject the example and fail the build.

>          interrupt-parent = <&extioiic>;
>          interrupts = <22 IRQ_TYPE_LEVEL_LOW>;
>          #address-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608024533.32419-1-wanghongliang@loongson.cn?part=1