From: sashiko-bot@kernel.org
To: "Hrushiraj Gandhi" <hrushirajg23@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 1/2] dt-bindings: arm: rockchip: add Vicharak Axon board
Date: Mon, 08 Jun 2026 06:14:41 +0000 [thread overview]
Message-ID: <20260608061441.E32351F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260608060940.52549-2-hrushirajg23@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 'vicharak' vendor prefix is not documented in vendor-prefixes.yaml.
--
commit 251502e367242a8cf17898614f2b1bad4718e71f
Author: Hrushiraj Gandhi <hrushirajg23@gmail.com>
dt-bindings: arm: rockchip: add Vicharak Axon board
This commit adds the device tree binding for the Vicharak Axon single-board
computer based on the Rockchip RK3588 SoC.
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1a9dde18626d0..b023d4cc9842e 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
[ ... ]
> @@ -1306,6 +1306,11 @@ properties:
> - const: turing,rk1
> - const: rockchip,rk3588
>
> + - description: Vicharak Axon
> + items:
> + - const: vicharak,axon
[Severity: Low]
Does the "vicharak" vendor prefix need to be documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml as part of this
change?
It looks like this introduces a new vendor prefix. Without registering it in
the vendor prefixes registry, it might cause a schema validation warning
when running make dt_binding_check.
> + - const: rockchip,rk3588
> +
> - description: WolfVision PF5 mainboard
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260608060940.52549-1-hrushirajg23@gmail.com?part=1
next prev parent reply other threads:[~2026-06-08 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 6:09 [PATCH v7 0/2] arm64: dts: rockchip: add Vicharak Axon board support Hrushiraj Gandhi
2026-06-08 6:09 ` [PATCH v7 1/2] dt-bindings: arm: rockchip: add Vicharak Axon board Hrushiraj Gandhi
2026-06-08 6:14 ` sashiko-bot [this message]
2026-06-08 6:09 ` [PATCH v7 2/2] arm64: dts: " Hrushiraj Gandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608061441.E32351F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hrushirajg23@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox