Re: [PATCH v2 2/7] wifi: ath11k: enable support for WCN6851

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added WCN6855 hw1.1 support is missing a corresponding MODULE_FIRMWARE() declaration in pci.c.
--

commit f54482207008ed0cfb8ad9e52b108a170f4c03af
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

wifi: ath11k: enable support for WCN6851

The WCN6851, found e.g. on SM8350 platforms, is an earlier version of
WCN6855 platform. It identifies itself as hw1.1. Copy WCN6855 hw 2.0
configuration to support hw1.1 version.

> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
> index 8dacc878c0068..78a226ca081c7 100644
> --- a/drivers/net/wireless/ath/ath11k/core.c
> +++ b/drivers/net/wireless/ath/ath11k/core.c
> @@ -393,6 +393,98 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
>  		.cfr_num_stream_bufs = 0,
>  		.cfr_stream_buf_size = 0,
>  	},
> +	{
> +		.name = "wcn6855 hw1.1",
> +		.hw_rev = ATH11K_HW_WCN6855_HW11,
> +		.fw = {
> +			.dir = "WCN6855/hw1.1",

[Severity: Medium]
Since this adds a new firmware directory for hw1.1, should there be a
corresponding MODULE_FIRMWARE(ATH11K_FW_DIR "/WCN6855/hw1.1/*") declaration
added to drivers/net/wireless/ath/ath11k/pci.c alongside the existing
entries for hw2.0 and hw2.1? 

Missing this might cause tools like modinfo or dracut to not recognize the
dependency, potentially leaving the firmware out of the initramfs.

> +			.board_size = 256 * 1024,
> +			.cal_offset = 128 * 1024,
> +		},

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608-sm8350-wifi-v2-0-efb68f1ff04c@oss.qualcomm.com?part=2