Re: [PATCH v0 5/7] ASoC: codecs: ES8389: Add private members related to HPF

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing newline `\n` in `dev_dbg` format strings.
--

commit 237c4458de0007d329850d65722e75250d0003bc
Author: Zhang Yi <zhangyi@everest-semi.com>

ASoC: codecs: ES8389: Add private members related to HPF

This commit adds private members related to the High Pass Filter (HPF)
for the ES8389 codec. It introduces device property reads during probe
to configure these values.

> diff --git a/sound/soc/codecs/es8389.c b/sound/soc/codecs/es8389.c
> --- a/sound/soc/codecs/es8389.c
> +++ b/sound/soc/codecs/es8389.c
[ ... ]
> @@ -905,6 +907,18 @@ static int es8389_probe(struct snd_soc_component *component)
>  		es8389->mclk_src = ES8389_MCLK_SOURCE;
>  	}
>  
> +	ret = device_property_read_u8(component->dev, "everest,hpfl", &es8389->hpfl);
> +	if (ret != 0) {
> +		dev_dbg(component->dev, "hpfl return %d", ret);

[Severity: Low]
Is there a missing newline at the end of this dev_dbg format string?

> +		es8389->hpfl = ES8389_HPF_DEFAULT;
> +	}
> +
> +	ret = device_property_read_u8(component->dev, "everest,hpfr", &es8389->hpfr);
> +	if (ret != 0) {
> +		dev_dbg(component->dev, "hpfr return %d", ret);

[Severity: Low]
Does this dev_dbg format string also need a terminating newline?

> +		es8389->hpfr = ES8389_HPF_DEFAULT;
> +	}
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608083540.12581-1-zhangyi@everest-semi.com?part=5