From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6325E78F39 for ; Mon, 8 Jun 2026 14:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780927319; cv=none; b=F8PpDZbL/5Rrb/+qLNVNLfFFMZrgnaaRum0hqhpKYyUKtTs8rRn1mzGZUnrYwF+pUgmdulx53eywvRzvdmDm2GOLpdkfAa/VEe6GwEKfLrlkzlyV2YUmeg+b26MfQI28t8DaQF80G//PyKGP0rfaZdXbZaepPZJLX4gEvBndRLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780927319; c=relaxed/simple; bh=GTMVdGI1xpvoUNvNPcV6rxR0thM5MbxsV8eBponbFY4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=NUtJgAmAwdkn5D9eNMFvvpXVklXv06gw3TE9/naRbxDUuj7icMb7G/y5gkJGv3yCvMcPB1Cw3ICTchSAXXbijnZnNR+rxEEcCEEb8rNOBXHzWjaHIYk1v3DYeQaTibFh8N7ZaDJgO+HPfFebANjXL0pns4xKkuNAXbpiqEgxYZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nB/zxlzI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nB/zxlzI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C38A81F00893; Mon, 8 Jun 2026 14:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780927318; bh=Pxn0AYNETLXETnw8RDsdRddUMaRYYLmIeOVzUwb1LZ8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=nB/zxlzIIsyXaj0l4mxSVtSVr5cxCELw+ZN5NQOn9S0GiiNwQ3z+zW+5PkPWsPiFz d3NBFYNhSUNPoXD8p1CCdt6HkXzXDOsY6bjoXhuB0/Bge3rIeVGhp1/AqRTxZOCc+2 Sw14a5l5P4kxOh98KMY1O94UqGs6IHnvGuBLdHx/VrW6ygGH/UrKxKIUq183Tk2gEp Ex73oOuCbUW4VJvHb/+wACqupwCc5fOZ130BMTAwmy//g+k6/oYUHezxqz4kS8zGv2 uQWMWD6npfVCncVSSygYO+Oj1S17KDO1yP/Sm3/rILroiZSd9ljzq72ut4bECbQ6AQ A3+DEqUtkt7iQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 3/4] dt-bindings: mfd: syscon: Drop custom select for older dtschema Reply-To: sashiko-reviews@lists.linux.dev To: "Krzysztof Kozlowski" Cc: robh@kernel.org, wsa+renesas@sang-engineering.com, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260608-n-dt-bindings-simple-bus-syscon-v2-3-0203e6c249dc@oss.qualcomm.com> References: <20260608-n-dt-bindings-simple-bus-syscon-v2-3-0203e6c249dc@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 08 Jun 2026 14:01:57 +0000 Message-Id: <20260608140157.C38A81F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Removal of the custom `select` block breaks device tree validati= on for `dtschema` versions older than 2024.02, which are still permitted by= the kernel build system. -- commit f0ac964d90c2fab365a733b219f9d7ce636b7fb6 Author: Krzysztof Kozlowski dt-bindings: mfd: syscon: Drop custom select for older dtschema This commit removes a custom select block from the syscon binding that was previously required for compatibility with dtschema versions older than 2024.02. The change aims to reduce duplication and prevent errors when addi= ng new compatible strings. > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Document= ation/devicetree/bindings/mfd/syscon.yaml > index e228670880631..fe882d3f828b1 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -19,122 +19,6 @@ description: | > maintainers: > - Lee Jones > =20 > -# Need a select with all compatibles listed for compatibility with older > -# dtschema (<2024.02), so this will not be selected for other schemas ha= ving > -# syscon fallback. > -select: > - properties: [Severity: Medium] Will removing this select block break schema validation for toolchain versions that are still officially permitted? Looking at Documentation/devicetree/bindings/Makefile, the minimum supported version is currently explicitly maintained as: DT_SCHEMA_MIN_VERSION =3D 2023.9 Since the kernel build system still officially supports dtschema versions between 2023.9 and 2024.01, wouldn't dropping this select cause syscon.yaml to erroneously apply to all syscon nodes and generate false-positive schema validation failures for users on those older versions? [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260608-n-dt-bindi= ngs-simple-bus-syscon-v2-0-0203e6c249dc@oss.qualcomm.com?part=3D3