Re: [PATCH v5 3/4] arm64: dts: freescale: add LVDS overlays for TQMa8MPxS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The standalone LVDS device tree overlays (.dtbo) are missing from the `dtb-$(CONFIG_ARCH_MXC)` target list, preventing them from being installed during `make dtbs_install`.
--

commit 94b1840d6358cc9ef625151682b73d4e243336ca
Author: Paul Gerber <paul.gerber@tq-group.com>

arm64: dts: freescale: add LVDS overlays for TQMa8MPxS
    
This adds device tree overlays for the Tianma tm070jvhg33 LVDS display
for TQMa8MPxS boards. It configures both LVDS channels with explicit
display timings to achieve a 519.75 MHz LDB clock.

> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 7a1d8586ce7c8..f0779a5d3b737 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
[ ... ]
> @@ -379,6 +379,11 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtbo
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-lvds-tm070jvhg33.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-lvds-tm070jvhg33-imx219.dtb
>  
> +imx8mp-tqma8mpqs-mb-smarc-2-lvds0-tm070jvhg33-dtbs += imx8mp-tqma8mpqs-mb-smarc-2.dtb imx8mp-tqma8mpqs-mb-smarc-2-lvds0-tm070jvhg33.dtbo
> +imx8mp-tqma8mpqs-mb-smarc-2-lvds1-tm070jvhg33-dtbs += imx8mp-tqma8mpqs-mb-smarc-2.dtb imx8mp-tqma8mpqs-mb-smarc-2-lvds1-tm070jvhg33.dtbo
> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpqs-mb-smarc-2-lvds0-tm070jvhg33.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpqs-mb-smarc-2-lvds1-tm070jvhg33.dtb
> +

[Severity: Medium]
Should the standalone .dtbo files also be explicitly added to
dtb-$(CONFIG_ARCH_MXC)?

If the standalone overlays are omitted from the target list, they will not
be installed during make dtbs_install.

While the combined .dtb is installed, missing the .dtbo files might prevent
applying the overlays dynamically via the bootloader. Other overlays in this
file appear to explicitly add the .dtbo to the build targets.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608142144.564871-1-alexander.stein@ew.tq-group.com?part=3