Re: [PATCH v2 2/2] iio: temperature: tmp117: add TI TMP119 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] TMP119 devices are incorrectly assigned `tmp117_channels_info` during hardware probe, resulting in the wrong IIO device name.
--

commit 39dc1c3727920cc7af5409c8327a8bd65880f8b8
Author: Wil Stark <wil_stark@keysight.com>

iio: temperature: tmp117: add TI TMP119 support

This commit adds support for the TMP119 temperature sensor. It introduces
the device ID, channel info, and matching data to allow the tmp117 driver
to handle TMP119 devices.

> diff --git a/drivers/iio/temperature/tmp117.c b/drivers/iio/temperature/tmp117.c
> index 8972083d903a2..18ad40f3e7361 100644
> --- a/drivers/iio/temperature/tmp117.c
> +++ b/drivers/iio/temperature/tmp117.c

[ ... ]

> @@ -170,6 +177,7 @@ static int tmp117_probe(struct i2c_client *client)
>  		match_data = &tmp116_channels_info;
>  		break;
>  	case TMP117_DEVICE_ID:
> +	case TMP119_DEVICE_ID:
>  		match_data = &tmp117_channels_info;
>  		break;

[Severity: Medium]
Will this assignment cause TMP119 devices to be registered with the wrong name?

By falling through to the TMP117_DEVICE_ID case, match_data is assigned to
&tmp117_channels_info rather than the newly added tmp119_channels_info.

As a result, TMP119 devices are exposed to userspace in the IIO subsystem
with the name 'tmp117' instead of 'tmp119'. The new tmp119_channels_info
struct appears to be completely bypassed during the hardware probe unless
identification fails and fallback match data is used.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608-tmp119-v2-0-30c3537d5097@bootlin.com?part=2