Re: [PATCH V6 6/6] arm64: dts: rockchip: Add Anbernic RG Vita-Pro

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The SPI joysticks are inaccessible from userspace due to a missing SPI child node.
--

commit 2097a3f0d4026d4220ee53d9f1d7508fedf974d2
Author: Chris Morgan <macromorgan@hotmail.com>

arm64: dts: rockchip: Add Anbernic RG Vita-Pro

This commit adds a device tree for the Anbernic RG Vita-Pro based on the
Rockchip RK3576. It sets up definitions and configurations for various
hardware components like display, buttons, battery, and networking.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts b/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
> new file mode 100644
> index 0000000000000..344ba18705338
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
> @@ -0,0 +1,1327 @@

[ ... ]

> +&spi1 {
> +	num-cs = <1>;
> +	pinctrl-0 = <&spi1m2_pins>, <&spi1m2_csn0>;
> +	status = "okay";
> +
> +	/* SPI controlled MCU for joystick and joystick LEDs. */
> +};

[Severity: High]
The commit message mentions "2 Analog joysticks controlled via userspace",
and this comment notes an SPI controlled MCU for the joystick. However,
there is no child node defined under this &spi1 controller.

Without a child node binding to a driver, the SPI core will not instantiate
a logical device, preventing userspace from communicating with the
joysticks. Could a spidev or similar child node be added here to expose the
interface?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608175521.67449-1-macroalpha82@gmail.com?part=6