Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jakub Szczudlo <jakubszczudlo40@gmail.com>
Cc: linux-iio@vger.kernel.org, dlechner@baylibre.com,
	nuno.sa@analog.com, andy@kernel.org, marcelo.schmitt@analog.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	mike.looijmans@topic.nl, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, jorge.marques@analog.com,
	antoniu.miclaus@analog.com, mazziesaccount@gmail.com,
	jishnu.prakash@oss.qualcomm.com, duje@dujemihanovic.xyz,
	wens@kernel.org, sakari.ailus@linux.intel.com, linusw@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: Update title and enum
Date: Mon, 8 Jun 2026 18:57:50 +0100	[thread overview]
Message-ID: <20260608185750.02c4242b@jic23-huawei> (raw)
In-Reply-To: <20260607183542.368184-2-jakubszczudlo40@gmail.com>

On Sun,  7 Jun 2026 20:35:40 +0200
Jakub Szczudlo <jakubszczudlo40@gmail.com> wrote:

> From: jszczudlo <jakubszczudlo40@gmail.com>
> 
> Add ads1110 into title and enum compatible for ads1100 driver.
> 
> Signed-off-by: jszczudlo <jakubszczudlo40@gmail.com>
Hi Jakub,

Obviously not related to your patch, but can we switch existing
pair of entries to be in alphabetical order whilst we do this?
Normally I'd ask for a separate patch for that, but given it's
so trivial and that would create churn vs your patch, do it
in one go (but make sure to mention it in the patch description!)



> ---
>  Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml
> index 970ccab15e1e..4c43996b7ec6 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/iio/adc/ti,ads1100.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: TI ADS1100/ADS1000 single channel I2C analog to digital converter
> +title: TI ADS1100/ADS1000/ADS1110 single channel I2C analog to digital converter
This is on the edge of the normal problem of never ending title growth
that we cheat to solve by saying something like

title: TI ADS1100 and similar single channel I2C Analog to Digital Converters

When we do that though we tend to include a bulleted list of parts in the
description: section.  Whilst I was looking at that I noticed we only reference
one datasheet which I'd assume doesn't cover this new part?  Perhaps that needs
updating as well?

Thanks,

Jonathan
>  
>  maintainers:
>    - Mike Looijmans <mike.looijmans@topic.nl>
> @@ -17,6 +17,7 @@ properties:
>      enum:
>        - ti,ads1100
>        - ti,ads1000
> +      - ti,ads1110
>  
>    reg:
>      maxItems: 1


  parent reply	other threads:[~2026-06-08 17:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-07 18:35 [PATCH 0/3] iio: adc: Extend ti-ads1100 driver Jakub Szczudlo
2026-06-07 18:35 ` [PATCH 1/3] dt-bindings: iio: adc: Update title and enum Jakub Szczudlo
2026-06-08 17:30   ` Conor Dooley
2026-06-08 17:57   ` Jonathan Cameron [this message]
2026-06-07 18:35 ` [PATCH 2/3] iio: adc: Update Kconfig description for TI_ADS1100 Jakub Szczudlo
2026-06-08  6:45   ` Joshua Crofts
2026-06-08 11:43     ` Andy Shevchenko
2026-06-08 17:53       ` Jonathan Cameron
2026-06-07 18:35 ` [PATCH 3/3] iio: adc: Add ti-ads1110 support to ti-ads1100 driver Jakub Szczudlo
2026-06-07 18:50   ` sashiko-bot
2026-06-08  7:39   ` Joshua Crofts
2026-06-08 18:03     ` Jonathan Cameron
2026-06-08 18:23   ` Jonathan Cameron
2026-06-08  6:42 ` [PATCH 0/3] iio: adc: Extend " Joshua Crofts
2026-06-08 11:42 ` Andy Shevchenko
2026-06-08 18:25 ` Jonathan Cameron
2026-06-09 16:10 ` David Lechner
2026-06-13 14:44   ` Jakub Szczudło

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260608185750.02c4242b@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=duje@dujemihanovic.xyz \
    --cc=jakubszczudlo40@gmail.com \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=jorge.marques@analog.com \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mike.looijmans@topic.nl \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox