Re: [PATCH v3 1/3] dt-bindings: mfd: syscon: Disallow simple-bus with syscon

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces several new compatible strings (e.g., `ti,am3352-scm-conf`) to the exception list without documenting them in any valid dt-binding schema. This causes a bisectability breakage in `dtbs_check` during the series and leaves permanent 'undocumented compatible' warnings at the end of the series.
--

commit 0cddec624a3b6ba2f0c447b95621f32101d2e31f
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: mfd: syscon: Disallow simple-bus with syscon

This commit adds a schema to disallow the combination of syscon and
simple-bus compatibles. It includes an exception list for legacy
configurations that currently rely on this pattern.

> diff --git a/Documentation/devicetree/bindings/mfd/syscon-common.yaml b/Documentation/devicetree/bindings/mfd/syscon-common.yaml
> index 14a08e7bc8bdd..2d5eef5add544 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon-common.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon-common.yaml
[ ... ]
> @@ -52,11 +53,44 @@ allOf:
>            contains:
>              const: simple-mfd
>      then:
> +      # Always require a specific compatible for syscon with simple-mfd
>        properties:
>          compatible:
>            minItems: 3
>            maxItems: 5
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: simple-bus
> +    then:
> +      # simple-bus conflicts with syscon - if a device is a system controller
> +      # with miscellaneous registers, then it has at least one dedicated
> +      # function thus it is not a simple bus. Allow existing exceptions.
> +      if:
> +        properties:
> +          compatible:
> +            not:
> +              contains:
> +                # This list CANNOT grow

[Severity: Medium]
Will this break bisectability for dtbs_check? Since the DTS files are
updated later in the series, it seems like existing TI DTS files using syscon
and simple-bus without these new specific compatibles will fail validation
when this patch is applied.

> +                enum:
> +                  - cznic,turris1x-cpld
> +                  - img,pistachio-cr-periph
> +                  - ti,am3352-scm-conf
> +                  - ti,am4372-scm-conf
> +                  - ti,dm814-scm-conf
> +                  - ti,dm8168-scm-conf
> +                  - ti,dra7-scm-conf
> +                  - ti,omap2-scm-conf
> +                  - ti,omap3-scm-conf
> +                  - ti,omap4-sysc-padconf-global
> +                  - ti,omap5-scm-wkup-conf
> +                  - ti,omap5-sysc-padconf-global

[Severity: Medium]
Are these new TI compatible strings documented in a dedicated binding schema?

Being listed inside this enum block doesn't document them for dtschema, which
might result in continuous undocumented compatible warnings for all the
updated TI boards at the end of the series.

> +      then:
> +        required:
> +          - incorrect-usage-of-simple-bus-and-syscon

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608-n-dt-bindings-simple-bus-syscon-v3-0-4eba9ec1212a@oss.qualcomm.com?part=1