From: sashiko-bot@kernel.org
To: "Neo Chang" <YLCHANG2@nuvoton.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60
Date: Tue, 09 Jun 2026 02:49:25 +0000 [thread overview]
Message-ID: <20260609024925.ADDC51F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260609024128.585938-2-YLCHANG2@nuvoton.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line bulleted list in the `reg` property description will be incorrectly rendered as a single run-on sentence.
--
commit 8aebb4f09e40762bba8c3a19ef3a2fd493c6de6d
Author: Neo Chang <YLCHANG2@nuvoton.com>
ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60
Add device tree bindings documentation for the Nuvoton NAU83G60
audio amplifier.
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml
> new file mode 100644
> index 0000000000000..2d19aedf1419a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml
> @@ -0,0 +1,83 @@
[ ... ]
> + reg:
> + maxItems: 1
> + description:
> + The I2C address of the device. The address is determined by the external
> + hardware configuration of GPIO1 and GPIO2 pins.
> + - 0x1a (GPIO2=Low, GPIO1=Low)
> + - 0x1b (GPIO2=Low, GPIO1=High)
> + - 0x4a (GPIO2=High, GPIO1=Low)
> + - 0x4b (GPIO2=High, GPIO1=High)
[Severity: Low]
This isn't a bug, but does this description block need a block scalar literal
indicator (`|`)?
In YAML, plain scalars that span multiple lines fold newlines into spaces
unless a block scalar indicator is used. Without the `|` indicator, this
bulleted list of I2C addresses might be concatenated into a continuous,
unformatted string in the generated documentation.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260609024128.585938-1-YLCHANG2@nuvoton.com?part=1
next prev parent reply other threads:[~2026-06-09 2:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 2:41 [PATCH v4 0/2] ASoC: codecs: Add Nuvoton NAU83G60 audio codec driver Neo Chang
2026-06-09 2:41 ` [PATCH v4 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60 Neo Chang
2026-06-09 2:49 ` sashiko-bot [this message]
2026-06-09 2:41 ` [PATCH v4 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier Neo Chang
2026-06-09 2:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609024925.ADDC51F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=YLCHANG2@nuvoton.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox