Re: [PATCH v4 4/4] net: phy: at803x: add RX and TX clock management for IPQ5018 PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The use of `devm_clk_get_enabled()` makes 'rx' and 'tx' clocks mandatory, breaking backward compatibility with older Device Trees where these properties are absent.
--

commit f4405a562aab15670004ca1eb487237c7985a67a
Author: George Moussalem <george.moussalem@outlook.com>

net: phy: at803x: add RX and TX clock management for IPQ5018 PHY

Acquire and enable the RX and TX clocks for the IPQ5018 PHY.
These clocks are required for the PHY's datapath to function correctly.

> diff --git a/drivers/net/phy/qcom/at803x.c b/drivers/net/phy/qcom/at803x.c
> index 63726cf98cd42..ba4dc07752b60 100644
> --- a/drivers/net/phy/qcom/at803x.c
> +++ b/drivers/net/phy/qcom/at803x.c
[ ... ]
> @@ -1084,6 +1086,16 @@ static int ipq5018_probe(struct phy_device *phydev)
>  	priv->set_short_cable_dac = of_property_read_bool(dev->of_node,
>  							  "qcom,dac-preset-short-cable");
>  
> +	rx_clk = devm_clk_get_enabled(dev, "rx");
> +	if (IS_ERR(rx_clk))
> +		return dev_err_probe(dev, PTR_ERR(rx_clk),
> +				     "failed to get and enable RX clock\n");
> +
> +	tx_clk = devm_clk_get_enabled(dev, "tx");
> +	if (IS_ERR(tx_clk))
> +		return dev_err_probe(dev, PTR_ERR(tx_clk),
> +				     "failed to get and enable TX clock\n");

[Severity: High]
Does this break backward compatibility with older Device Trees that do not
specify these clock properties?

Using devm_clk_get_enabled() makes these clocks mandatory, which will cause
ipq5018_probe() to fail unconditionally with -ENOENT if they are missing.

Could this be changed to use devm_clk_get_optional_enabled() so the interface
continues to work with older Device Trees while still enabling the clocks
when they are present?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608-ipq5018-gephy-clocks-v4-0-fb2ccd56894b@outlook.com?part=4