Re: [PATCH v2 1/2] dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing schema validation constraints for `qcom,ipq9650-tsens` due to omitted compatible string in `allOf` conditional blocks.
--

commit 4b153774882bf21dfe2ec762bc94eb3a253bf2ac
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible

Add the compatible for the thermal sensors on the ipq5210 and ipq9650. The
ipq5210 uses ipq5332-tsens as a fallback, while ipq9650 is added as a
standalone v2 TSENS compatible with combined interrupt.

> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index 7d34ba00e684f..a927650c119b9 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -92,6 +92,13 @@ properties:
>            - qcom,ipq5332-tsens
>            - qcom,ipq5424-tsens
>            - qcom,ipq8074-tsens
> +          - qcom,ipq9650-tsens

[Severity: Medium]
Should qcom,ipq9650-tsens also be added to the allOf conditional blocks that
enforce constraints for related TSENS v2 hardware?

The commit message mentions this is a v2 TSENS compatible with a combined
interrupt. However, it appears the compatible string was omitted from the
if-then blocks further down in the schema.

For example, the conditional that enforces interrupt-names must be 'combined'
currently checks:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,ipq5332-tsens
              - qcom,ipq5424-tsens
              - qcom,ipq8074-tsens

Similarly, the conditional that enforces the reg property is strictly required
for v2 variants omits qcom,ipq9650-tsens.

Without being added to those conditional blocks, won't nodes using
qcom,ipq9650-tsens silently pass dt_binding_check validation even if they omit
the reg property or have incorrect interrupt-names?

> +
> +      - description: v2 of TSENS with combined interrupt
> +        items:
> +          - enum:
> +              - qcom,ipq5210-tsens
> +          - const: qcom,ipq5332-tsens
>  
>        - description: v2 of TSENS with combined interrupt
>          items:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609065447.4024695-1-varadarajan.narayanan@oss.qualcomm.com?part=1