Re: [PATCH v3 2/3] arm64: dts: qcom: Add Eliza CQS SoM platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The device tree source includes `pm7550ba-eliza.dtsi`, which does not exist in the source tree, causing a C preprocessor failure during compilation.
- [Low] References to device tree labels `&sdhc_1`, `&sdc1_default`, `&sdc1_sleep`, and `&remoteproc_adsp` lack definitions in the base SoC device tree (`eliza.dtsi`).
--

commit 49ba8d899e255d89a8013a6ccd6b518c9f069ea6
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: Add Eliza CQS SoM platform

This commit adds the Eliza CQS System-on-Module DTSI file. It describes
the regulators, board clocks, eMMC support, and ADSP firmware.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> new file mode 100644
> index 0000000000000..33f4cd2822724
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> @@ -0,0 +1,394 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +
> +#include "eliza.dtsi"
> +#include "pm7550ba-eliza.dtsi"

[Severity: Low]
Is pm7550ba-eliza.dtsi missing from the tree? It doesn't appear to be added
in this commit or present in the baseline, which causes a preprocessor
failure during compilation.

[ ... ]

> +&remoteproc_adsp {
> +	firmware-name = "qcom/eliza/adsp.mbn",
> +			"qcom/eliza/adsp_dtb.mbn";
> +
> +	status = "okay";
> +};

[Severity: Low]
Is the &remoteproc_adsp label defined in the base eliza.dtsi? Compiling
this device tree fails with a reference to a non-existent node or label.

> +
> +&sdhc_1 {
> +	vmmc-supply = <&vreg_l12b>;
> +	vqmmc-supply = <&vreg_l1d>;
> +	pinctrl-0 = <&sdc1_default>;
> +	pinctrl-1 = <&sdc1_sleep>;
> +	pinctrl-names = "default", "sleep";

[Severity: Low]
Are the labels &sdhc_1, &sdc1_default, and &sdc1_sleep defined? They appear
to be missing from eliza.dtsi and the included files, leading to a build
failure.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-eliza-dts-qcs-evk-v3-0-b4e9b033a6dc@oss.qualcomm.com?part=2