Re: [PATCH 1/2] bindings: power: supply: qcom,pmic-glink: Document thermal-mitigation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `#cooling-cells` property in the `qcom,pmic-glink.yaml` schema breaks devicetree validation.
--

commit 0b39bda76eaec494654108cde4e92f788edf6f16
Author: Dhruvin Rajpura <drajpura@qti.qualcomm.com>

bindings: power: supply: qcom,pmic-glink: Document thermal-mitigation

This commit documents the qcom,thermal-mitigation property for the PMIC
GLINK schema. It defines an array of fast charge current limits used by the
thermal framework for battery throttling.

> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index ff01d2f3ee5be..fcb69ebaa7cb5 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -58,6 +58,16 @@ properties:
>        The array should contain a gpio entry for each PMIC Glink connector, in reg order.
>        It is defined that GPIO active level means "CC2" or Reversed/Flipped orientation.
>  
> +  qcom,thermal-mitigation:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description:
> +      Array of fast charge current limit values for different system thermal

[Severity: Medium]
Does this introduce a regression by missing the #cooling-cells property?

By adding qcom,thermal-mitigation, the device acts as a thermal framework
cooling provider. For a platform devicetree to actually reference this
cooling provider in a thermal zone, the provider node must declare the
#cooling-cells property.

Since the schema limits which properties can be added, won't platforms
fail validation when they try to declare #cooling-cells to wire up this new
capability?

> +      mitigation levels. This should be a flat array that denotes the maximum
> +      charging current (in uA) for each thermal level. Elements should be listed
> +      in monotonically decreasing (non-increasing) order.
> +    minItems: 1
> +    maxItems: 10
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-cooling_device_reg-v1-0-e15bddcb0086@qti.qualcomm.com?part=1