From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3786139C00B for ; Tue, 9 Jun 2026 10:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781001405; cv=none; b=vDM46FTlTgR0vdEsxWFWE157jz5PtayAOTYo3CQnsvRNImDpG5f3x88qi22PszvAZQ2YLeTAyhtXa7YXST3KSVZThAl0lbCDOkSQjr2sMqYi1e3zSeY1p7Eno4OeWa9oxRL/Lgv563uwzkJLsrIay11JvRnIEqZoYSCDgleiSio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781001405; c=relaxed/simple; bh=JnI1bY8Gb1Soa7mjmy4GgKwWVBj1KINKgnqdYLwpSdE=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=uk5wH/2gDtpMcKNfJXpOa97kOr7iSKrBZ2Jm/28wuMvFRPppHN9KxrWlFNi84wsLvn1gHI4Be9NKnQUSlEvnUA6GHZwZFumn9dwPi/ycRtSzxOr/GrYzSqeYs9cs74nMtFK+wwrX3k2AdLFfP8sfMR6GXqATFd7f5UW2hMKk1uE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l0mLw/F/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l0mLw/F/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45B631F00893; Tue, 9 Jun 2026 10:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781001403; bh=lHDdbiKdPZj7YuQzL4RuAunVPjB7tZt8h8gC/zZbYDc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=l0mLw/F/67xYz8wDVGejwGtXa1Qx9oA84sNzXfS/eLfWt3CpsnGspVXVIcUJnF1Gp cQ/toVv/QG7r9U3nMhuSYDbTiyZDVks102fb4t7bTZq+gdDyxMzOI1UbahCHMV++Ac OmuZPWC2zqeWHo68uJC5TVwm+/J+kc8lYrRPFZsmUyHrMqxDV16DYeWLYziYwca9CA zwlVa9WUhuE9H+MVketiZSNUBwetKq6cfCKZOmHUhvPp1zf2HSoRonytyHd8xrWjNm jMKg3JP4lfr4zSqMeakb2BoW3KQ2pbhuDxqZI0Q0Xk5iW276+0nk4tlEZolteLs24+ gLnpGZI092bMA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 1/8] dt-bindings: remoteproc: qcom,pas: add thermal mitigation properties Reply-To: sashiko-reviews@lists.linux.dev To: "Gaurav Kohli" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260609-qmi-tmd-v3-1-291a2ff4c634@oss.qualcomm.com> References: <20260609-qmi-tmd-v3-1-291a2ff4c634@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 09 Jun 2026 10:36:42 +0000 Message-Id: <20260609103643.45B631F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [Medium] The `#cooling-cells` property uses an `enum` constraint instead = of a hardware-matching `const` constraint. - [Medium] Schema fails to enforce the mutual dependency between `#cooling-= cells: 3` and `tmd-names`. - [Low] The newly introduced 'tmd-names' property is missing the 'qcom,' ve= ndor prefix. -- commit ff18b7a7814a6d6f6545f74edd22e93602470084 Author: Gaurav Kohli Date: Tue Jun 9 10:22:56 2026 +0000 dt-bindings: remoteproc: qcom,pas: add thermal mitigation properties Document Qualcomm PAS remoteproc thermal mitigation properties used for QMI-based throttling. > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common= .yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml > index 4607b459131b4..0d07a07507620 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml > @@ -79,6 +79,20 @@ properties: > channels and devices related to the ADSP. > unevaluatedProperties: false > =20 > + '#cooling-cells': > + description: > + Number of cooling cells; 2 for min/max cooling state and 3 when > + selecting a thermal mitigation device index. > + enum: [2, 3] [Severity: Medium] The device tree bindings guidelines state that each cell-count property must have a const constraint matching the hardware. Is it possible to enforce a strict const constraint in the specific hardware variant schemas rather than allowing an enum here, so we prevent misconfigured device tree nodes from passing validation? > + > + tmd-names: [Severity: Low] Since this property is specific to Qualcomm's QMI-based thermal mitigation device (TMD) throttling mechanism and not a standard core thermal binding, should this have the "qcom," vendor prefix added to avoid namespace collisions? > + $ref: /schemas/types.yaml#/definitions/string-array > + description: > + Names of the thermal mitigation devices available in remote proces= sor > + subsystem. > + minItems: 1 > + maxItems: 5 [Severity: Medium] The #cooling-cells description mentions that a cell count of 3 is used to select a thermal mitigation device index. Does this mean tmd-names should be strictly required when #cooling-cells is 3?=20 If so, should we add an allOf or if-then conditional block tying these two properties together to prevent validation of incomplete nodes? > + > glink-edge: --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260609-qmi-tmd-v3= -0-291a2ff4c634@oss.qualcomm.com?part=3D1