Re: [PATCH 07/12] clk: qcom: gcc-mdm9607: Drop incorrect apss_tcu_clk_src

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing `apss_tcu_clk_src` leaves the static constant arrays `gcc_xo_gpll0_gpll1_gpll2` and `gcc_xo_gpll0_gpll1_gpll2_map` completely unused.
--

commit 358707fc8fbfb6b33cbd35ecd5569222e1050407
Author: Stephan Gerhold <stephan@gerhold.net>

clk: qcom: gcc-mdm9607: Drop incorrect apss_tcu_clk_src

This commit removes the apss_tcu_clk_src clock from the MDM9607 GCC driver
as it does not seem to exist on this hardware. Reading or writing its
registers results in 0 or crashes, and its frequency table math was
broken.

> diff --git a/drivers/clk/qcom/gcc-mdm9607.c b/drivers/clk/qcom/gcc-mdm9607.c
> --- a/drivers/clk/qcom/gcc-mdm9607.c
> +++ b/drivers/clk/qcom/gcc-mdm9607.c
[ ... ]
> @@ -677,26 +677,6 @@ static struct clk_rcg2 sdcc2_apps_clk_src = {
>  	},
>  };
>  
> -static const struct freq_tbl ftbl_gcc_apss_tcu_clk[] = {
> -	F(155000000, P_GPLL2, 6, 0, 0),
> -	F(310000000, P_GPLL2, 3, 0, 0),
> -	F(400000000, P_GPLL0, 2, 0, 0),
> -	{ }
> -};
> -
> -static struct clk_rcg2 apss_tcu_clk_src = {
> -	.cmd_rcgr = 0x1207c,
> -	.hid_width = 5,
> -	.parent_map = gcc_xo_gpll0_gpll1_gpll2_map,

[Severity: Low]
Does the removal of apss_tcu_clk_src leave gcc_xo_gpll0_gpll1_gpll2_map
unused?

It looks like this clock was the sole user of this static array. Leaving it
unreferenced might cause -Wunused-const-variable compiler warnings.

> -	.freq_tbl = ftbl_gcc_apss_tcu_clk,
> -	.clkr.hw.init = &(struct clk_init_data){
> -		.name = "apss_tcu_clk_src",
> -		.parent_data = gcc_xo_gpll0_gpll1_gpll2,

[Severity: Low]
Similarly, does this also leave the gcc_xo_gpll0_gpll1_gpll2 static array
unused?

If there are no other references in drivers/clk/qcom/gcc-mdm9607.c, it
should likely be removed as well to prevent dead code and warnings.

> -		.num_parents = 4,
> -		.ops = &clk_rcg2_ops,
> -	},
> -};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-qcom-clk-mdm9607-fixes-v1-0-5e9717faf842@linaro.org?part=7