Re: [PATCH 5/5] arm64: dts: renesas: Add LCDC overlays for RZ/T2H and RZ/N2H EVKs with ADV7513

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The RZ/N2H overlay fails to disable conflicting devices (`led-7`, `key-1`, and `sdhi1`), causing pinctrl and physical hardware collisions.
- [Low] Typo in the Makefile causes the composite DTB for the RZ/N2H EVK to be incorrectly named with 'rzt2h' instead of 'rzn2h'.
--

commit efe0a5ca8f3fdb36ded9b05e9b5a45260bb5135a
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

arm64: dts: renesas: Add LCDC overlays for RZ/T2H and RZ/N2H EVKs with ADV7513

This commit adds device tree overlay support to enable the DU/LCDC pipeline
on the RZ/T2H and RZ/N2H evaluation kits. It configures the overlays for use
with a CN15/CN20 ADV7513 HDMI transmitter.

> diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
> index ca45d2857ea7f..0f64a8820e374 100644
> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
[ ... ]
> @@ -215,8 +215,14 @@ r9a09g057h48-kakip-pixpaper-dtbs := r9a09g057h48-kakip.dtb r9a09g057h48-kakip-pi
>  dtb-$(CONFIG_ARCH_R9A09G057) += r9a09g057h48-kakip-pixpaper.dtb
>  
>  dtb-$(CONFIG_ARCH_R9A09G077) += r9a09g077m44-rzt2h-evk.dtb
> +dtb-$(CONFIG_ARCH_R9A09G077) += r9a09g077m44-evk-cn15-lcdc.dtbo
> +r9a09g077m44-rzt2h-evk-cn15-lcdc-dtbs := r9a09g077m44-rzt2h-evk.dtb r9a09g077m44-evk-cn15-lcdc.dtbo
> +dtb-$(CONFIG_ARCH_R9A09G077) += r9a09g077m44-rzt2h-evk-cn15-lcdc.dtb
>  
>  dtb-$(CONFIG_ARCH_R9A09G087) += r9a09g087m44-rzn2h-evk.dtb
> +dtb-$(CONFIG_ARCH_R9A09G087) += r9a09g087m44-evk-cn20-lcdc.dtbo
> +r9a09g087m44-rzt2h-evk-cn20-lcdc-dtbs := r9a09g087m44-rzn2h-evk.dtb r9a09g087m44-evk-cn20-lcdc.dtbo
> +dtb-$(CONFIG_ARCH_R9A09G087) += r9a09g087m44-rzt2h-evk-cn20-lcdc.dtb

[Severity: Low]
Does this code contain a copy-paste typo? The target is the RZ/N2H EVK, but
the variables use rzt2h instead of rzn2h for the composite DTB names.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g087m44-evk-cn20-lcdc.dtso b/arch/arm64/boot/dts/renesas/r9a09g087m44-evk-cn20-lcdc.dtso
> new file mode 100644
> index 0000000000000..bc8a91278920e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a09g087m44-evk-cn20-lcdc.dtso
[ ... ]
> +&{/leds/led-4} {
> +	/* P18_1 is used for DU function LCDC_DATB2. */
> +	status = "disabled";
> +};
> +
> +&i2c0 {
> +	status = "disabled";
> +};

[Severity: Medium]
Does this overlay omit disabling conflicting devices like led-7, key-1, and
sdhi1?

The shared DU overlay configures du-pins to use P18_2 for LCDC_DATB3 and
P14_3 for LCDC_DATG3. In the base RZ/N2H device tree, P18_2 is statically
assigned to key-1 and P14_3 is assigned to led-7. Leaving them enabled could
lead to a pinctrl collision during boot.

Also, the overlay specifies that LCDC_DATG3 requires hardware switch DSW5[3]
to be OFF, but sdhi1 in the base device tree requires DSW5[3] to be ON for
card detect and IO voltage supply. Could sdhi1 be explicitly disabled here as
well to prevent physical hardware conflicts?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609125353.401124-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=5