Re: [PATCH v6 4/7] clk: qcom: videocc: Add video clock controller driver for Eliza

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] video_cc_ahb_clk_src incorrectly sets .hw_clk_ctrl = true.
--

commit 17dde18cb6830ef09380f666b54112994b478845
Author: Taniya Das <taniya.das@oss.qualcomm.com>

clk: qcom: videocc: Add video clock controller driver for Eliza

This commit adds support for the video clock controller on the Eliza platform.
It allows video clients to request videocc clocks for video encoding and
decoding functionality.

> diff --git a/drivers/clk/qcom/videocc-eliza.c b/drivers/clk/qcom/videocc-eliza.c
> new file mode 100644
> index 0000000000000..36af35e070299
> --- /dev/null
> +++ b/drivers/clk/qcom/videocc-eliza.c

[ ... ]

> +static const struct freq_tbl ftbl_video_cc_ahb_clk_src[] = {
> +	F(19200000, P_BI_TCXO, 1, 0, 0),
> +	{ }
> +};
> +
> +static struct clk_rcg2 video_cc_ahb_clk_src = {
> +	.cmd_rcgr = 0x8018,
> +	.mnd_width = 0,
> +	.hid_width = 5,
> +	.parent_map = video_cc_parent_map_0,
> +	.freq_tbl = ftbl_video_cc_ahb_clk_src,
> +	.hw_clk_ctrl = true,

[Severity: High]
Does this incorrectly set the hardware clock control flag on the
software-controlled AHB RCG?

Because video_cc_ahb_clk_src is an AHB bus clock, it is purely software
controlled. If the hardware clock control flag is set, when
clk_rcg2_shared_ops attempts to park the clock at initialization by writing
to CFG_REG and triggering the CMD_UPDATE bit, the hardware will wait
indefinitely for a hardware trigger that never arrives.

This causes update_config() to timeout, emit a warning, and fail to apply the
configuration, effectively leaving the clock stuck in its bootloader state.

> +	.clkr.hw.init = &(const struct clk_init_data) {
> +		.name = "video_cc_ahb_clk_src",
> +		.parent_data = video_cc_parent_data_0,
> +		.num_parents = ARRAY_SIZE(video_cc_parent_data_0),
> +		.flags = CLK_SET_RATE_PARENT,
> +		.ops = &clk_rcg2_shared_ops,
> +	},
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-b4-eliza_mm_cc_v6-v6-0-17df09e5940c@oss.qualcomm.com?part=4