Re: [PATCH v5 12/15] ASoC: qcom: sm8250: add SDM660 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add the compatible string for SDM670 devices, but it is completely missing from the implementation.
--

commit 075844a100dc2d901b8571b7631f5698eae8be05
Author: Richard Acayan <mailingradian@gmail.com>

ASoC: qcom: sm8250: add SDM660 compatible

This commit adds support for SDM660 devices to use WCD codecs
connected to internal MI2S.

> Add the compatible for SDM660 and SDM670 devices, which can use the
> support for WCD codecs connected to internal MI2S.

> diff --git a/sound/soc/qcom/sm8250.c b/sound/soc/qcom/sm8250.c
> index 1952c599e004f..76dc3a3f4a312 100644
> --- a/sound/soc/qcom/sm8250.c
> +++ b/sound/soc/qcom/sm8250.c
> @@ -210,6 +210,7 @@ static const struct of_device_id snd_sm8250_dt_match[] = {
>  	{ .compatible = "qcom,qrb2210-sndcard", .data = "qcm2290" },
>  	{ .compatible = "qcom,qrb4210-rb2-sndcard", .data = "sm4250" },
>  	{ .compatible = "qcom,qrb5165-rb5-sndcard", .data = "sm8250" },
> +	{ .compatible = "qcom,sdm660-sndcard", .data = "sdm660" },

[Severity: Medium]
The commit message indicates that this patch adds the compatible string
for SDM670 devices, but only the SDM660 compatible is added here in
snd_sm8250_dt_match.

Was the SDM670 compatible intentionally omitted from the array, or should
the commit message be updated to match the code?

>  	{ .compatible = "qcom,sm8250-sndcard", .data = "sm8250" },
>  	{}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609162255.31074-1-mailingradian@gmail.com?part=12