Re: [PATCH v5 11/15] ASoC: qcom: sm8250: add support for LPI_MI2S_RX_0 and LPI_MI2S_TX_3

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Hardware clock leak: MI2S sysclks are enabled on startup but never disabled on shutdown
--

commit d56ecb81f1a498d069991569b37a6e2d484e4d23
Author: Richard Acayan <mailingradian@gmail.com>

ASoC: qcom: sm8250: add support for LPI_MI2S_RX_0 and LPI_MI2S_TX_3

This commit adds support for the LPI_MI2S_RX_0 and LPI_MI2S_TX_3 ports to
the sm8250 machine driver. It configures the DAI formats and sets the
sysclk for these new ports in the startup callback.

> diff --git a/sound/soc/qcom/sm8250.c b/sound/soc/qcom/sm8250.c
> index f193d0ba63d00..1952c599e004f 100644
> --- a/sound/soc/qcom/sm8250.c
> +++ b/sound/soc/qcom/sm8250.c
> @@ -112,6 +112,22 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
>  		snd_soc_dai_set_fmt(cpu_dai, fmt);
>  		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
>  		break;
> +	case LPI_MI2S_RX_0:
> +		codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> +		snd_soc_dai_set_sysclk(cpu_dai,
> +			Q6AFE_LPASS_CLK_ID_INT0_MI2S_IBIT,
> +			MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);

[Severity: High]
This is a pre-existing issue, but does this code leak the hardware clock?

The machine driver enables the DSP MI2S IBIT clocks via
snd_soc_dai_set_sysclk() during stream startup, which sends an
AFE_PARAM_ID_CLOCK_SET command to the DSP.

However, looking at the rest of the driver, the associated .shutdown
callback (qcom_snd_sdw_shutdown) is specific to SoundWire and ignores
MI2S DAIs.

Because there is no matching logic to call snd_soc_dai_set_sysclk() with
a 0 frequency on stream close, will the DSP clock remain permanently
enabled after the first playback and prevent the DSP and SoC from
entering deep sleep states?

> +		snd_soc_dai_set_fmt(cpu_dai, fmt);
> +		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> +		break;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609162255.31074-1-mailingradian@gmail.com?part=11