Re: [PATCH v2] dt-bindings: leds: bcm6358: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The LED sub-node uses `additionalProperties: false` alongside `$ref: common.yaml#`, which silently rejects standard LED properties.
- [Low] Unused `#include <dt-bindings/leds/common.h>` in the device tree example.
--

commit 7f21f3b199b43205368512a4bc4314dd320036e1
Author: Ninad Naik <ninadnaik07@gmail.com>

dt-bindings: leds: bcm6358: Convert to DT schema

This commit converts the text bindings for the Broadcom BCM6358 LED
controller to DT schema.

> diff --git a/Documentation/devicetree/bindings/leds/brcm,bcm6358-leds.yaml b/Documentation/devicetree/bindings/leds/brcm,bcm6358-leds.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/brcm,bcm6358-leds.yaml
[ ... ]
> +patternProperties:
> +  "^led@(0|1?[0-9a-f])$":
> +    type: object
> +    $ref: common.yaml#
> +    description: Each LED is represented as a sub-node of
> +      this device.
> +
> +    properties:
> +      reg:
> +        description: LED pin number (0 to 31).
> +        maxItems: 1
> +
> +      label: true
> +
> +      default-state: true
> +
> +      linux,default-trigger: true
> +
> +      active-low: true
> +
> +    required:
> +      - reg
> +
> +    additionalProperties: false

[Severity: Medium]
Does this restrict the child node to only locally declared properties,
rejecting the standard LED properties inherited from common.yaml#?

In DT schemas, additionalProperties does not consider properties evaluated
via a $ref. Could this cause validation errors if standard LED properties
are used in the device tree? Should unevaluatedProperties: false be used
here instead?

> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/leds/common.h>

[Severity: Low]
This isn't a bug, but the header is included here without any of its macros
being referenced in the example nodes.

> +    led-controller@fffe00d0 {
> +        compatible = "brcm,bcm6358-leds";
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        reg = <0xfffe00d0 0x8>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609181731.1379846-1-ninadnaik07@gmail.com?part=1