Re: [PATCH v6 06/11] arm64: dts: ti: var-som-am62p: Fix wkup R5F memory region size

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately describes the prior state of the code. It claims that `wkup_r5fss0_core0_memory_region` was reserved with "only 0x0f00000" (15 MiB) and implies it is being increased to `0x1d08000`. However, the diff reveals the previous value was actually `0x01e00000` (30 MiB), meaning the patch is shrinking the reservation rather than expanding it from `0x0f00000`. The commit message appears to have been copied from another patch.
--

commit f780a29b02dfe26af92ddc65f0520382d3c6c8e7
Author: Markus Schneider-Pargmann (TI) <msp@baylibre.com>

arm64: dts: ti: var-som-am62p: Fix wkup R5F memory region size

This commit updates the wkup_r5fss0_core0_memory_region size in the device
tree for the AM62P platform. The size is adjusted to match the MCU SDK linker
expectations for the wkup R5F firmware.

Link: https://github.com/TexasInstruments/mcupsdk-core-k3/blob/k3_main/examples/drivers/ipc/ipc_rpmsg_echo_linux/am62px-sk/wkup-r5fss0-0_freertos/ti-arm-clang/linker.cmd

> The wkup_r5fss0_core0_memory_region was reserved with only
> 0x0f00000 but the MCU SDK linker for the wkup R5F firmware on
> AM62P defines the DM code/data DDR footprint differently:

[Severity: Medium]
Is this description of the prior state accurate?

The commit message states the region was reserved with only 0x0f00000,
which implies the patch is increasing the size.

However, looking at the device tree changes in this patch:

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-var-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62p5-var-som.dtsi
> --- a/arch/arm64/boot/dts/ti/k3-am62p5-var-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-var-som.dtsi
> @@ -71,7 +71,7 @@ wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 {
>  
>  		wkup_r5fss0_core0_memory_region: r5f-memory@9c900000 {
>  			compatible = "shared-dma-pool";
> -			reg = <0x00 0x9c900000 0x00 0x01e00000>;
> +			reg = <0x00 0x9c900000 0x00 0x01d08000>;

The previous value was actually 0x01e00000 (30 MiB), meaning the region is
being shrunk to 0x01d08000 rather than expanded from 0x0f00000.

Could the commit message be updated to reflect the actual previous value being
replaced in the device tree?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-topic-am62a-ioddr-dt-v6-19-v6-0-16afba97fbe0@baylibre.com?part=6