From: sashiko-bot@kernel.org
To: "John Madieu" <john.madieu.xa@bp.renesas.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
wsa+renesas@sang-engineering.com
Subject: Re: [PATCH v3] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-names and ports schema
Date: Tue, 09 Jun 2026 21:38:55 +0000 [thread overview]
Message-ID: <20260609213856.0C4611F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260609212921.1706886-1-john.madieu.xa@bp.renesas.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unimplemented Commit Claim: Missing clocks and resets constraints
--
commit 57b95b37a13d07fcffc98c59354ae1c916fe8d6f
Author: John Madieu <john.madieu.xa@bp.renesas.com>
ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-names and ports schema
This commit simplifies the dma-names schema, updates the ports container
reference, and removes unused top-level address and size cells. It also
updates the example node order and clock specifiers, and states it pins
clocks and resets to fixed counts.
> diff --git a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> index d7fa165546985..b539e84ead8da 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> @@ -42,12 +42,6 @@ properties:
> "#clock-cells":
> const: 0
>
> - "#address-cells":
> - const: 1
> -
> - "#size-cells":
> - const: 0
> -
> clocks:
> maxItems: 47
[Severity: Medium]
The commit message mentions it will "pin clocks and resets to their fixed
counts (47 and 14) to match the clock-names/reset-names lists." Did a hunk
get dropped during a rebase?
The patch doesn't appear to add minItems: 47 to the clocks property here, nor
does it add minItems: 14 to the corresponding resets property.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260609212921.1706886-1-john.madieu.xa@bp.renesas.com?part=1
prev parent reply other threads:[~2026-06-09 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 21:29 [PATCH v3] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-names and ports schema John Madieu
2026-06-09 21:38 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609213856.0C4611F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=john.madieu.xa@bp.renesas.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox