Re: [PATCH v8 02/10] reset: Add Realtek basic reset support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Generic module name `common.ko` pollutes the global kernel module namespace.
--

commit 67818ad9f005d500ae216802db2e67d2214119c7
Author: Cheng-Yu Lee <cylee12@realtek.com>

reset: Add Realtek basic reset support

This commit defines common reset operations backed by a regmap-based register
interface for Realtek SoCs. It prepares a common reset framework to extract
the regmap and device tree node from the parent device.

> diff --git a/drivers/reset/realtek/Makefile b/drivers/reset/realtek/Makefile
> new file mode 100644
> index 0000000000000..b59a3f7f2453e
> --- /dev/null
> +++ b/drivers/reset/realtek/Makefile
> @@ -0,0 +1,2 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +obj-$(CONFIG_RESET_RTK_COMMON) += common.o

[Severity: Low]
Does this create a module with an overly generic name?

Since CONFIG_RESET_RTK_COMMON is a tristate configuration, building it as a
module will directly produce a kernel module named common.ko. Because kernel
module names occupy a global, flat namespace, this name lacks any vendor or
subsystem prefix.

Could this risk future naming collisions with other subsystems or confuse
users managing modules? Building this as a composite object with a more
descriptive name, such as reset-rtk-common.ko, might prevent this.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610080824.255063-1-eleanor.lin@realtek.com?part=2