From: sashiko-bot@kernel.org
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: hwmon: ina2xx: add ina232 compatible
Date: Wed, 10 Jun 2026 08:41:10 +0000 [thread overview]
Message-ID: <20260610084110.95B9A1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260610-monza-ina232-v1-1-925b0d12771b@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `ti,ina232` compatible string was added to the top-level enum but omitted from the existing `if-then` conditional blocks that restrict unsupported properties.
--
commit 3cd10611f4c71e7280e19fcd316cd7a918042ee6
Author: Martino Facchin <m.facchin@arduino.cc>
dt-bindings: hwmon: ina2xx: add ina232 compatible
The INA232 is a current/power monitor from Texas Instruments sharing
the same register map as the other INA2xx.
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> index 009d78b308596..a30888c9156b9 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> @@ -28,6 +28,7 @@ properties:
> - ti,ina228
> - ti,ina230
> - ti,ina231
> + - ti,ina232
[Severity: Low]
Does this new compatible string need to be added to the allOf conditional
blocks further down in the schema file?
By omitting ti,ina232 from the exclusion list for
ti,maximum-expected-current-microamp, the schema might incorrectly allow
this property for ti,ina232 nodes:
allOf:
- if:
properties:
compatible:
contains:
enum:
- silergy,sq52206
...
- ti,ina231
- ti,ina234
- ti,ina237
then:
properties:
ti,maximum-expected-current-microamp: false
Should ti,ina232 be added alongside ti,ina231 here?
Similarly, ti,ina232 appears to be omitted from the conditional block
restricting ti,shunt-gain:
- if:
properties:
compatible:
contains:
enum:
- silergy,sy24655
...
- ti,ina231
- ti,ina234
- ti,ina260
then:
properties:
ti,shunt-gain: false
Could this weaken schema validation when checking device tree nodes for
this specific hardware variant?
> - ti,ina233
> - ti,ina234
> - ti,ina237
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260610-monza-ina232-v1-0-925b0d12771b@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-06-10 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 8:32 [PATCH 0/3] Add INA232 power monitor support for Arduino VENTUNO Q Loic Poulain
2026-06-10 8:32 ` [PATCH 1/3] dt-bindings: hwmon: ina2xx: add ina232 compatible Loic Poulain
2026-06-10 8:41 ` sashiko-bot [this message]
2026-06-10 9:01 ` Loic Poulain
2026-06-10 8:32 ` [PATCH 2/3] hwmon: ina2xx: support ina232 Loic Poulain
2026-06-10 8:43 ` sashiko-bot
2026-06-10 9:26 ` Loic Poulain
2026-06-10 8:32 ` [PATCH 3/3] arm64: dts: qcom: monaco-arduino-monza: add ina232 power sensor Loic Poulain
2026-06-10 8:37 ` sashiko-bot
2026-06-10 8:52 ` Loic Poulain
2026-06-10 8:54 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610084110.95B9A1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox