Re: [PATCH v2 03/16] power: sequencing: Change CONFIG_POWER_SEQUENCING to bool

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message incorrectly justifies changing CONFIG_POWER_SEQUENCING to bool by falsely claiming that USB support is a boolean option, which unnecessarily prevents building the power sequencing subsystem as a module.
--

commit 80f4a7ca3dbefd1dc2ae2274d131e8b5461c5c66
Author: Chen-Yu Tsai <wenst@chromium.org>

power: sequencing: Change CONFIG_POWER_SEQUENCING to bool

This commit changes the POWER_SEQUENCING Kconfig option from tristate
to bool, citing that USB support cannot be built as a module.

> USB support, including the core and hub driver, is bool, no modules. To
> be able to use the power sequencing API in the USB core, the former must
> also be bool to avoid the latter being built as a module.

[Severity: Medium]
Is this description of USB support accurate? Looking at drivers/usb/Kconfig,
CONFIG_USB is actually defined as a tristate:

config USB
        tristate "Support for Host-side USB"

Since the USB core can indeed be built as a loadable module, does
POWER_SEQUENCING strictly need to be restricted to bool here? Could standard
Kconfig patterns like depends on POWER_SEQUENCING || POWER_SEQUENCING=n be
used instead if linkage dependencies need to be resolved?

> diff --git a/drivers/power/sequencing/Kconfig b/drivers/power/sequencing/Kconfig
> index 1c5f5820f5b76..27448fba9dc5d 100644
> --- a/drivers/power/sequencing/Kconfig
> +++ b/drivers/power/sequencing/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  
>  menuconfig POWER_SEQUENCING
> -	tristate "Power Sequencing support"
> +	bool "Power Sequencing support"

[Severity: Medium]
Given that CONFIG_USB is a tristate, does this change unnecessarily prevent
the power sequencing subsystem from being built as a module?

>  	help
>  	  Say Y here to enable the Power Sequencing subsystem.
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610084053.2059858-1-wenst@chromium.org?part=3