Re: [PATCH v1 3/3] arm64: dts: imx8mm-var-dart: Add support for Variscite Sonata board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Commit message claims 'HDMI support', but the device tree does not contain any display or HDMI nodes.
- [Low] Unused pinmux configuration for GPIO4_IO22 in SPI pin group.
--

commit 4503e51abf44d2c1fc12465dd4301df16f97a703
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: imx8mm-var-dart: Add support for Variscite Sonata board

Add device tree support for the Variscite Sonata carrier board with the
DART-MX8M-MINI system on module.

Link: https://variscite.com/carrier-boards/sonata-board/

> The Sonata board includes
> - uSD Card support
> - USB ports and OTG
> - Uart, SPI and I2C interfaces
> - HDMI support

[Severity: Medium]
The commit message claims "HDMI support", but looking at the provided device
tree, there don't appear to be any display-related nodes such as LCDIF,
MIPI DSI, a DSI-to-HDMI bridge, or an hdmi-connector. Does this patch actually
include the HDMI support mentioned in the description?

> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
> new file mode 100644
> index 0000000000000..93b0076987b82
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts

[ ... ]

> +	pinctrl_ecspi1: ecspi1grp {
> +		fsl,pins = <
> +			MX8MM_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK		0x13
> +			MX8MM_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI		0x13
> +			MX8MM_IOMUXC_ECSPI1_MISO_ECSPI1_MISO		0x13
> +			MX8MM_IOMUXC_ECSPI1_SS0_GPIO5_IO9		0x13
> +			MX8MM_IOMUXC_GPIO1_IO12_GPIO1_IO12		0x13
> +			MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22		0x13
> +		>;
> +	};

[Severity: Low]
Does the ECSPI1 controller or any of its connected devices actually use this
MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 pin? 

The ecspi1 node explicitly defines its chip selects as <&gpio5 9> and
<&gpio1 12>, and it doesn't appear to reference this GPIO. 

Could this be an unused pinmux configuration left over from a copy-paste that
might conflict with other functions needing this pin?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1781024557.git.stefano.r@variscite.com?part=3