From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E9553EDE76 for ; Wed, 10 Jun 2026 10:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781086551; cv=none; b=G6LXIwYSDMojLId71tG4EcmByhFOzsk4ObcwCpRiXIzOGiruhKX9eoY5ej7ojYLCnbT1nNpU3zSFdXhotrxTwWKhBnMkZoPpcCxacHRV/X/8/Jg0Z/8G8TbiKybwBqMjV1tMwbnOW+Z72dAC7n1ZjukpnNTUyTFnh6zIe5TMu78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781086551; c=relaxed/simple; bh=NrtbrHsbqjcuKqy75mbvY8XaB/5latQ043Q5aVfYoO0=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=XPfI/Z1qmeLavEPuCSVR1UaTDh21XUYri+91/GR8Q6eHnnqyAvM/Gm6bFf25Tn0zdl7SFok8cVQk2ZMIAusvJWH0Q8yi5jlMRurIqflA/bT3kO1d3W+tDx3GbdyQXINIDRIDQwZRYenVqtHKT4jKzDal8B5yHqTQ7N1DQh+1A9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k0JTVeiN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k0JTVeiN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 743E01F00893; Wed, 10 Jun 2026 10:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781086549; bh=Xl6B1n/zAl/JNPQJ9Rf+05hJwG6rsMeINuZzVBO1JXw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=k0JTVeiNE+NZKqpRV/JHf4lU7U3EYsMly6ejylIx6uGv7krbgzrRGZhdhAM6j0MTg H36UcUfvI5pkd/w4qM732oWNlKPgsXQpswdEOjEQsvwPBjn91V4/eTZhEMxbM1WPs0 Ll3s/45T+0pCuZUisO63EXiCs00JQQF0fhwGMyMmN5J85McOV8pzdsrPCSH3RaWi3V tD5h3u8LBhHgQKa3wyLYYD8bLBT/fhTwIlMarXM1czwxzqn/FwzV27EOq8jclF9YA+ L4JpKczp7+tTOJc1knPpm3H/0DJvi8nshOoTBpsOvE5nANr1se7SAjbZ5UxvjhRA11 eaPJGJjKygRgg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add HINLINK H28K Reply-To: sashiko-reviews@lists.linux.dev To: "Chukun Pan" Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260610100006.366963-3-amadeus@jmu.edu.cn> References: <20260610100006.366963-3-amadeus@jmu.edu.cn> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 10 Jun 2026 10:15:47 +0000 Message-Id: <20260610101549.743E01F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The newly added device tree `rk3528-hinlink-h28k.dts` fails to comp= ile because it references undefined USB node labels. -- commit 07ca37acc11522d114428bc076a631a2223bfa47 Author: Chukun Pan Subject: arm64: dts: rockchip: Add HINLINK H28K This commit introduces a new device tree for the HINLINK H28K (LinkStar H28K) single-board computer based on the Rockchip RK3528 SoC. It adds support for basic features including Ethernet, eMMC, MicroSD, and USB. > diff --git a/arch/arm64/boot/dts/rockchip/rk3528-hinlink-h28k.dts b/arch/= arm64/boot/dts/rockchip/rk3528-hinlink-h28k.dts > new file mode 100644 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3528-hinlink-h28k.dts [ ... ] > +&uart0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&uart0m0_xfer>; > + status =3D "okay"; > +}; > + > +&usb2phy { > + status =3D "okay"; > +}; > + > +&usb2phy_host { > + phy-supply =3D <&vcc5v0_sys>; > + status =3D "okay"; > +}; > + > +&usb_host0_ehci { > + status =3D "okay"; > +}; > + > +&usb_host0_ohci { > + status =3D "okay"; > +}; [Severity: Low] Are these USB node labels defined in the included rk3528.dtsi at this revision? It appears that referencing &usb2phy, &usb2phy_host, &usb_host0_ehci, and &usb_host0_ohci here will cause a DTC build failure with a "Label or path not found" error because the underlying node labels do not seem to exist yet in the included trees. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260610100006.3669= 63-1-amadeus@jmu.edu.cn?part=3D2