Re: [PATCH v2 2/2] riscv: dts: sophgo: Add Milk-V Duo 256M board support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [High] The device tree references an undefined label `&usb`, which will cause a fatal dtc compilation error.
- [Medium] The commit message claims to add support for an 'Onboard blue status LED', but the corresponding LED node is completely missing from the device tree.
- [Low] Accidental removal of the trailing newline at the end of the Makefile.
- [Low] Potentially stale or incomplete copyright attribution in the new DTS file.
--

commit 1a0c595fbd52010c818ad842d5ef53c54212434e
Author: Chen-Yu Yeh <chenyou910331@gmail.com>

riscv: dts: sophgo: Add Milk-V Duo 256M board support

The Milk-V Duo 256M is a small form factor development board based on
the Sophgo SG2002 SoC.

>     - Onboard blue status LED (connected to PWR_GPIO[2] / porte 2)
>     
>     Tested on actual Milk-V Duo 256M hardware, verified boot to shell and
>     heartbeat LED functionality.

[Severity: Medium]
Is the LED node missing from the device tree? The commit message mentions
support and verification for an onboard blue status LED, but there does
not seem to be a corresponding leds or gpio-leds node in the patch.

> diff --git a/arch/riscv/boot/dts/sophgo/Makefile b/arch/riscv/boot/dts/sophgo/Makefile
> --- a/arch/riscv/boot/dts/sophgo/Makefile
> +++ b/arch/riscv/boot/dts/sophgo/Makefile

[ ... ]

>  dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-evb-v1.dtb
>  dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-evb-v2.dtb
> -dtb-$(CONFIG_ARCH_SOPHGO) += sg2044-sophgo-srd3-10.dtb
> +dtb-$(CONFIG_ARCH_SOPHGO) += sg2044-sophgo-srd3-10.dtb
> \ No newline at end of file

[Severity: Low]
this isn't a bug, but was the trailing newline accidentally removed from
the end of the Makefile?

> diff --git a/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts b/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts
> @@ -0,0 +1,108 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2023 Jisheng Zhang <jszhang@kernel.org>
> + */

[Severity: Low]
this isn't a bug, but is this copyright attribution stale? The file appears
to use a template from 2023, and it might be missing the 2026 copyright for
the current author.

> +
> +/dts-v1/;
> +
> +#include "sg2002.dtsi"
> +#include <dt-bindings/gpio/gpio.h>

[Severity: Medium]
Is this header still required? It seems unused in the newly added device
tree file, possibly because the LED node was accidentally dropped.

[ ... ]

> +&uart0 {
> +	pinctrl-0 = <&uart0_cfg>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +};
> +
> +&usb {
> +	dr_mode = "host";
> +	status = "okay";
> +};

[Severity: High]
Will this compile successfully? It looks like the usb label is not defined
in the included base SoC device tree files, which could cause a dtc syntax
error during the build.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610121026.1517621-1-chenyou910331@gmail.com?part=2