Re: [PATCH v4 2/3] arm64: dts: nuvoton: npcm845: Add peripheral nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] DTC Warning (unit_address_vs_reg): The `apb` node includes a unit address but lacks a `reg` property.
- [Low] DT Binding Schema Violation: `nuvoton,sysgcr` property is undocumented and forbidden by the ChipIdea USB2 schema.
--

commit b1b96db36d76cd5dd1f935613798ed29aade275d
Author: Tomer Maimon <tmaimon77@gmail.com>

arm64: dts: nuvoton: npcm845: Add peripheral nodes

Extend the NPCM845 SoC DTSI with the peripheral controller nodes needed
by the evaluation board and downstream platforms. Add the Ethernet MACs,
USB device controllers and PHY, MMC controller, FIU controllers, memory
controller, RNG, ADC, PWM/FAN controller, and I2C buses. Also add the
OP-TEE firmware node needed to describe these blocks.

> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 7976baafb9942..1e21b2704784f 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
[ ... ]
> @@ -51,7 +57,255 @@ clk: rstc: reset-controller@f0801000 {
>  			#clock-cells = <1>;
>  		};
>  
> -		apb {
> +		gmac1: ethernet@f0804000 {
[ ... ]
> +		udc8: usb@f0838000 {
> +			compatible = "nuvoton,npcm845-udc", "nuvoton,npcm750-udc";
> +			reg = <0x0 0xf0838000 0x0 0x1000
> +			       0x0 0xfffef000 0x0 0x800>;
> +			interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk NPCM8XX_CLK_SU>;
> +			clock-names = "clk_usb_bridge";
> +
> +			nuvoton,sysgcr = <&gcr 0x9C 0xC000 0xC000>;

[Severity: Low]
Does this undocumented nuvoton,sysgcr property cause a dtbs_check warning?

The USB Device Controllers bind to "nuvoton,npcm750-udc", which is evaluated 
against Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml. This schema 
specifies unevaluatedProperties: false but does not document nuvoton,sysgcr 
internally or in any dependencies.

> +			phys = <&udc0_phy>;
> +			phy_type = "utmi_wide";
> +			dr_mode = "peripheral";
> +			status = "disabled";
> +		};
> +
> +		udc9: usb@f0839000 {
> +			compatible = "nuvoton,npcm845-udc", "nuvoton,npcm750-udc";
> +			reg = <0x0 0xf0839000 0x0 0x1000
> +			       0x0 0xfffef800 0x0 0x800>;
> +			interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk NPCM8XX_CLK_SU>;
> +			clock-names = "clk_usb_bridge";
> +
> +			nuvoton,sysgcr = <&gcr 0x9C 0x3000 0x3000>;

[Severity: Low]
Is this the same undocumented property issue as seen above in udc8?

> +			phys = <&udc0_phy>;
> +			phy_type = "utmi_wide";
> +			dr_mode = "peripheral";
> +			status = "disabled";
> +		};
> +
[ ... ]
> +		fiux: spi@fb001000 {
> +			compatible = "nuvoton,npcm845-fiu";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x0 0xfb001000 0x0 0x1000>,
> +			<0x0 0xf8000000 0x0 0x2000000>;
> +			reg-names = "control", "memory";
> +			clocks =  <&clk NPCM8XX_CLK_SPIX>;
> +			status = "disabled";
> +		};
> +
> +		apb: bus@f0000000 {

[Severity: Low]
Will changing this node name to include the @f0000000 unit address 
trigger a unit_address_vs_reg DTC warning?

According to the Devicetree specification, if a node name includes a 
unit-address, the node must also have a reg property where the first 
address matches the unit-address. Because the apb node defines ranges 
but lacks a reg property, this might introduce build noise.

>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			compatible = "simple-bus";
> @@ -59,14 +313,6 @@ apb {
>  			ranges = <0x0 0x0 0xf0000000 0x00300000>,
>  				<0xfff00000 0x0 0xfff00000 0x00016000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610160816.2828713-1-tmaimon77@gmail.com?part=2