From: Krzysztof Kozlowski <krzk@kernel.org>
To: Amit Barzilai <amit.barzilai22@gmail.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
javierm@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: Add Solomon SSD1351 OLED controller
Date: Thu, 11 Jun 2026 12:39:26 +0200 [thread overview]
Message-ID: <20260611-psychedelic-funky-foxhound-a8e39d@quoll> (raw)
In-Reply-To: <20260610164428.180091-2-amit.barzilai22@gmail.com>
> +properties:
> + compatible:
> + enum:
> + - solomon,ssd1351
> +
> + solomon,width:
> + default: 128
> +
> + solomon,height:
> + default: 128
Drop both - deducible from the compatible.
> +
> + rotation: true
Either drop or reference panel-common (if this is a panel) or at least
reference that property:
$ref: /schemas/display/panel/panel-common.yaml#/properties/rotation
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + oled@0 {
> + compatible = "solomon,ssd1351";
> + reg = <0x0>;
> + reset-gpios = <&gpio2 7>;
> + dc-gpios = <&gpio2 8>;
Use proper defines for GPIO flags
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-11 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 16:44 [PATCH 0/2] drm: Add driver for the Solomon SSD1351 OLED controller Amit Barzilai
2026-06-10 16:44 ` [PATCH 1/2] dt-bindings: display: Add " Amit Barzilai
2026-06-10 16:54 ` sashiko-bot
2026-06-11 9:45 ` Javier Martinez Canillas
2026-06-11 10:39 ` Krzysztof Kozlowski [this message]
2026-06-15 18:10 ` Amit Barzilai
2026-06-10 16:44 ` [PATCH 2/2] drm/solomon: Add SSD1351 OLED display driver Amit Barzilai
2026-06-10 16:55 ` sashiko-bot
2026-06-19 13:52 ` Uwe Kleine-König
2026-06-11 9:44 ` [PATCH 0/2] drm: Add driver for the Solomon SSD1351 OLED controller Javier Martinez Canillas
2026-06-15 18:12 ` Amit Barzilai
2026-06-16 8:55 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260611-psychedelic-funky-foxhound-a8e39d@quoll \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=amit.barzilai22@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox