Re: [PATCH v2] dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect property name referenced in the description of `ti,irqs-skip`. The description refers to `ti,crossbar-irqs-reserved` instead of the actual property name `ti,irqs-reserved`.
--

commit 19def91a21d8fc01d4494e60735ef7f90bf2fedd
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema

This commit converts the TI irq-crossbar binding from text format to DT schema.
It also adds the missing '#interrupt-cells' property and moves the binding into
the interrupt-controller directory.

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml b/Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml
> new file mode 100644
> index 0000000000000..ec9a33511aae3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml

[ ... ]

> +  ti,irqs-reserved:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description:
> +      List of the reserved irq lines that are not muxed using crossbar. These
> +      interrupt lines are reserved in the soc, so crossbar bar driver should not
> +      consider them as free lines.
> +
> +  ti,irqs-skip:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description:
> +      Similar to "ti,crossbar-irqs-reserved", but these are for SOC-specific

[Severity: Low]
This isn't a bug, but there is a typo in the property name referenced here. The
original text binding correctly referred to "ti,irqs-reserved", but it was
mistakenly changed to "ti,crossbar-irqs-reserved" during the conversion. Should
this reference the actual property name "ti,irqs-reserved"?

> +      hard-wiring of those irqs which unexpectedly bypasses the crossbar. These
> +      irqs have a crossbar register, but still cannot be used.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260611-crossbar-v2-1-231d4f88298e@gmail.com?part=1