Re: [PATCH v7 2/2] ARM: dts: aspeed: ventura2: Add Meta ventura2 BMC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing `reg` property in flash nodes causes `unit_address_vs_reg` Device Tree compiler warnings.
- [Low] Device Tree node names violate naming conventions and will fail `dtbs_check` validation.
--

commit 2eeab78b32b1eec6637ab72a9ca3d05a4cfb0f70
Author: Kyle Hsieh <kylehsieh1995@gmail.com>

ARM: dts: aspeed: ventura2: Add Meta ventura2 BMC

This commit introduces the device tree for the Meta Ventura2 Rack
Management Controller (RMC). The system uses an AST2600 BMC for managing
liquid cooling systems, monitoring hardware states, and supports an extensive
I2C and IO expander topology.

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
> new file mode 100644
> index 0000000000000..12fad349e71b4
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
> @@ -0,0 +1,2897 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2023 Facebook Inc.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/i2c/i2c.h>
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
> +/ {
> +	model = "Facebook Ventura2 RMC";
> +	compatible = "facebook,ventura2-rmc", "aspeed,ast2600";

[ ... ]

> +	chosen {
> +		stdout-path = "serial4:57600n8";
> +	};
> +
> +	fan_leds {
        ^^^^^^^^

[Severity: Low]
Does this node name violate naming conventions? Device tree node names should
typically use hyphens instead of underscores (e.g., fan-leds) to pass dtbs_check
validation.

> +		compatible = "gpio-leds";
> +
> +		led-0 {

[ ... ]

> +&fmc {
> +	status = "okay";
> +
> +	flash@0 {
> +		status = "okay";
> +		m25p,fast-read;
> +		label = "bmc";
> +		spi-max-frequency = <50000000>;
> +		#include "openbmc-flash-layout-128.dtsi"
> +	};
> +
> +	flash@1 {
> +		status = "okay";
> +		m25p,fast-read;
> +		label = "alt-bmc";
> +		spi-max-frequency = <50000000>;
> +	};
> +};

[Severity: Low]
Are these flash nodes missing a reg property? Since the parent controller
defines #address-cells = <1>, omitting reg for nodes with a unit address
(e.g., flash@0, flash@1) will cause dtc to emit a unit_address_vs_reg warning.

[ ... ]

> +		i2c4mux0ch1: i2c@1 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <1>;
> +
> +			temp-sensor@48 {
                        ^^^^^^^^^^^

[Severity: Low]
Is this using a non-standard name? Device tree bindings for temperature sensors
typically expect temperature-sensor@ instead of temp-sensor@ to pass validation.
This pattern appears here and in the &i2c5 and &i2c10 nodes.

> +				compatible = "ti,tmp75";
> +				reg = <0x48>;
> +			};

[ ... ]

> +&spi2 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_spi2_default &pinctrl_spi2cs1_default>;
> +
> +	flash@0 {
> +		status = "okay";
> +		m25p,fast-read;
> +		label = "pnor";
> +		spi-max-frequency = <12000000>;
> +		spi-tx-bus-width = <2>;
> +		spi-rx-bus-width = <2>;
> +	};
> +
> +	flash@1 {
> +		status = "okay";
> +		m25p,fast-read;
> +		label = "e810";
> +		spi-max-frequency = <12000000>;
> +		spi-tx-bus-width = <2>;
> +		spi-rx-bus-width = <2>;
> +	};
> +};

[Severity: Low]
Are the flash nodes under spi2 missing a reg property as well? Just like
the fmc controller, nodes with unit addresses should include matching reg
properties.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260611-ventura2_initial_dts-v7-0-a61d8902bc5f@gmail.com?part=2