Re: [net-next v1 1/6] dt-bindings: net: dwmac: Add snps,use-ncsi property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Introduces a vendor-prefixed property (`snps,use-ncsi`) for a generic, standard hardware feature (NC-SI) that is already widely used without a prefix.
--

commit 9f79574dbd128266dea8e1a64bd86e9a7c9ea506
Author: Minda Chen <minda.chen@starfivetech.com>

dt-bindings: net: dwmac: Add snps,use-ncsi property

Add snps,use-ncsi dts bindings property for Synopsys designware
ethernet MAC with RMII interface and used as sideband interface
network controller(NCSI).

> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2449311c6d28e..05b1d8428f653 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -545,6 +545,13 @@ properties:
>        Enables the TSO feature otherwise it will be managed by MAC HW capability
>        register.
>  
> +  snps,use-ncsi:

[Severity: Medium]
Is a vendor prefix appropriate for this hardware feature?

NC-SI is a standard protocol supported by the kernel's core net/ncsi/
subsystem. It appears the boolean property use-ncsi is already a de-facto
standard used across the tree for this concept (such as in the ftgmac100
driver and ASPEED device trees).

Should this be formally documented as a generic property in
Documentation/devicetree/bindings/net/ethernet-controller.yaml and used
here without the vendor prefix to prevent fragmenting the ecosystem?

> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Use the NC-SI stack instead of an MDIO PHY. Currently assumes
> +      rmii (100bT) but kept as a separate property in case NC-SI grows support
> +      for a gigabit link.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610072420.64699-1-minda.chen@starfivetech.com?part=1