Re: [PATCH v10 4/6] clk: Add KUnit tests for assigned-clock-sscs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Extraneous `assigned-clock-sscs` properties injected into `u64` rate test overlays without accompanying test assertions.
--

commit 210e00ec864807cd43e4b4e5dca8755417d9ee5a
Author: Peng Fan <peng.fan@nxp.com>
Subject: clk: Add KUnit tests for assigned-clock-sscs

This commit adds KUnit test coverage for the assigned-clock-sscs device tree
property. It extends the dummy clock framework to support spread spectrum
configuration and introduces a new test suite with several scenarios,
including single assignments, multiple assignments, and malformed DT
properties. It also adds new DT overlays for these test scenarios.

> diff --git a/drivers/clk/kunit_clk_assigned_rates_u64_multiple.dtso b/drivers/clk/kunit_clk_assigned_rates_u64_multiple.dtso
> index 389b4e2eb7f74..3a717dab2d00b 100644
> --- a/drivers/clk/kunit_clk_assigned_rates_u64_multiple.dtso
> +++ b/drivers/clk/kunit_clk_assigned_rates_u64_multiple.dtso
> @@ -12,5 +12,11 @@ clk: kunit-clock {
>  				  <&clk 1>;
>  		assigned-clock-rates-u64 = /bits/ 64 <ASSIGNED_RATES_0_RATE>,
>  					   /bits/ 64 <ASSIGNED_RATES_1_RATE>;
> +		assigned-clock-sscs = <ASSIGNED_SSCS_0_MODFREQ
> +				       ASSIGNED_SSCS_0_SPREAD
> +				       ASSIGNED_SSCS_0_METHOD>,
> +				      <ASSIGNED_SSCS_1_MODFREQ
> +				       ASSIGNED_SSCS_1_SPREAD
> +				       ASSIGNED_SSCS_1_METHOD>;

[Severity: Low]
Looking at the kunit-clock node in
drivers/clk/kunit_clk_assigned_rates_u64_multiple.dtso, are these
assigned-clock-sscs properties necessary in the u64 rate test overlays?

The test cases utilizing these overlays only verify rate assignments and do
not assert anything about the parsed SSCS state. Since dedicated SSCS test
overlays were added, it seems these additions might be extraneous.

>  	};
>  };

[ ... ]

> diff --git a/drivers/clk/kunit_clk_assigned_rates_u64_one.dtso b/drivers/clk/kunit_clk_assigned_rates_u64_one.dtso
> index 87041264e8f54..9b04d6927f083 100644
> --- a/drivers/clk/kunit_clk_assigned_rates_u64_one.dtso
> +++ b/drivers/clk/kunit_clk_assigned_rates_u64_one.dtso
> @@ -10,5 +10,8 @@ clk: kunit-clock {
>  		#clock-cells = <0>;
>  		assigned-clocks = <&clk>;
>  		assigned-clock-rates-u64 = /bits/ 64 <ASSIGNED_RATES_0_RATE>;
> +		assigned-clock-sscs = <ASSIGNED_SSCS_0_MODFREQ
> +				       ASSIGNED_SSCS_0_SPREAD
> +				       ASSIGNED_SSCS_0_METHOD>;

[Severity: Low]
Similar to the multiple overlay, is this property needed in the kunit-clock
node of drivers/clk/kunit_clk_assigned_rates_u64_one.dtso for the u64 tests?

>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260612-clk-v10-v10-0-eb92484eda38@nxp.com?part=4