Re: [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing Compatible String in Conditional Block for 'qcom,pmk7750-gpio'
- [Low] Missing PMK7750 PMIC parent node in MFD bindings
--

commit 4f1189e771b6e33f2285b6ec22e2635e18bc5718
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750

Document Qualcomm PMK7750 GPIO used with Eliza SoC.  PMIC is almost the
same as PMK8550, thus compatible with it.

> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 386c31e9c52b8..5ecf5da3d1000 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -15,79 +15,84 @@ description:
>  
>  properties:
>    compatible:

[ ... ]

> +      - items:
> +          - enum:
> +              - qcom,pmk7750-gpio
> +          - const: qcom,pmk8550-gpio
> +          - const: qcom,spmi-gpio
>  
>    reg:
>      maxItems: 1

[Severity: Low]
Does the allOf conditional block for qcom,pmk8550-gpio need to be updated
to explicitly include qcom,pmk7750-gpio?

Looking at the existing conditional blocks further down in the file:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,pm8018-gpio
              - qcom,pm8019-gpio
              - qcom,pm8550vs-gpio
              - qcom,pmk8550-gpio
    then:

Since qcom,pmk7750-gpio is compatible with qcom,pmk8550-gpio, should it also
be explicitly listed in these constraints to ensure schema validation remains
complete?

[Severity: Low]
Does the parent PMIC qcom,pmk7750 need to be added to the MFD bindings in
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml?

The MFD binding strictly enforces exactly a two-element array:

  compatible:
    items:
      - enum:
          - qcom,pm2250
          ...
          - qcom,pmk8550
          ...
      - const: qcom,spmi-pmic

Since qcom,pmk7750-gpio is added here, will device trees fail schema
validation for the parent PMIC node if qcom,pmk7750 is missing from the
enum in qcom,spmi-pmic.yaml?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260612090426.23403-2-krzysztof.kozlowski@oss.qualcomm.com?part=1